New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of libbsds strlcpy #57

Closed

ofalk opened this issue Sep 9, 2020 · 1 comment

Owner

ofalk commented Sep 9, 2020 •

edited

Loading

fw.c: In function ‘arg_to_fr’:
fw.c:102:3: warning: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Wimplicit-function-declaration]
  102 |   strlcpy(fr->fw_device, argv[2], sizeof(fr->fw_device));
      |   ^~~~~~~
      |   strncpy

This is a non-standard glibc function and only available in libbsd.

The text was updated successfully, but these errors were encountered:

Owner Author

ofalk commented Sep 9, 2020

Fixing with simply replacing with strncpy leads to:

fw.c: In function ‘arg_to_fr’:
fw.c:103:3: warning: ‘strncpy’ specified bound 16 equals destination size [-Wstringop-truncation]
  103 |   strncpy(fr->fw_device, argv[2], sizeof(fr->fw_device));
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Yeah, null termination byte of course.

ofalk added a commit that referenced this issue


          Fix #57

ofalk closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment