Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow other units for width and height #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow other units for width and height #70

wants to merge 2 commits into from

Commits on Nov 21, 2021

  1. Update index.vue 

    Related to officert#37 

Updates conditional to check for a numeric panel height/width and if that's the case append `'px'`

Previously if `width: '50%'` were used we would end up with a width of `'50%px'`

Thanks a lot for this component, it's great!
    @jchristopher
    jchristopher authored Nov 21, 2021
    Configuration menu
    Copy the full SHA
    e142c5a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Improves height/width unit check conditional 

    `isNaN` has some edge cases, we can use a regular expression to check for digits instead.
    @jchristopher
    jchristopher authored Nov 22, 2021
    Configuration menu
    Copy the full SHA
    0d2875e View commit details
    Browse the repository at this point in the history