movecount pruning reduction logic

[praveentml]

This patch applies a extension to search reduction logic in case the position is not ttPv && !PvNode and is pruned based on move count

passed STC

https://tests.stockfishchess.org/tests/view/5e8092bde42a5c3b3ca2ed35

LLR: 2.94 (-2.94,2.94) {-0.50,1.50}

Total: 78848 W: 15480 L: 15170 D: 48198 Elo +1.05

Ptnml(0-2): 1406, 9310, 17773, 9438, 1497

passed LTC

https://tests.stockfishchess.org/tests/view/5e80bb13e42a5c3b3ca2ed4b

LLR: 2.94 (-2.94,2.94) {0.25,1.75}

Total: 86596 W: 11451 L: 11033 D: 64112 Elo +1.44

Ptnml(0-2): 624, 7993, 25687, 8329, 665

Bench: 5138771

[praveentml]

can someone help me to understand why these checks are failing ?

[vondele]

The bench number needs to be in the commit message, not just in this pull request, and must be the number that reflects this patch as applied to current master.
If you're using git, from the command line, try git commit --allow-empty -m "Bench: 5138771" or even better git rebase -i master and select 'reword' for the patch. Afterwards you might need to 'force push' your repository to github.

[praveentml]

why do I see elo difference in committed messages and fishtest tests.. any guidance please

[vondele]

The perfect commit message has them included, which is most easily done by creating a 'PR branch' after the test has passed fishtesting. That's also useful for rebasing and squashing the PR in final form.

However, if the commits in the PR do not have that information, the maintainer needs to assemble that from the PR comments prior to merging. That's a bit more work for him, and error-prone, but that's also what is most common.

If a PR contains a single commit and all the information, the PR comment will be automatically prefilled on github, so the patch author only needs to write it a single time.

[praveentml]

now the checks passed. what would be next steps ? Sorry for asking too many questions but since this is my first test which is passed and would like to understand the process

[vondele]

Basically, you're done, I'll merge this later.

Apart from a minor nit.... would you like to update the AUTHORS file as well, as part of this PR :-)

[praveentml]

yes please :-)

[vondele]

you'll need to modify AUTHORS, git commit and git push that again.

[praveentml]

Done. Thank you

[vondele]

merged, thanks!