Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and replace DoubledIsolated penalty by Doubled #2696

Closed

Conversation

ElbertoOne
Copy link

The values for both penalties were very close, so DoubledIsolated can be removed and replaced by Doubled.

Passed STC (simplification): https://tests.stockfishchess.org/tests/view/5ec7c18e2a585b485af54407
LLR: 2.97 (-2.94,2.94) {-1.50,0.50}
Total: 105360 W: 20175 L: 20136 D: 65049
Ptnml(0-2): 1803, 12230, 24572, 12275, 1800

Passed LTC:
LLR: 2.94 (-2.94,2.94) {-1.50,0.50}
Total: 15440 W: 1978 L: 1877 D: 11585
Ptnml(0-2): 92, 1405, 4667, 1422, 134

Bench: 4862947

@vondele
Copy link
Member

vondele commented May 23, 2020

@ElbertoOne this will need the correct bench added to the commit messages for it to pass CI.

I will also wait with merging to see if any of the Elo gainers related to doubled pawns that are running right now pass.

@ElbertoOne
Copy link
Author

@vondele I don't know why the tests are failing. When I run bench, the bench number as in the PR is shown (4862947). I added it to several commit messages.

@vondele
Copy link
Member

vondele commented May 23, 2020

@ElbertoOne It looks in the commit message for something in the form Bench: 4862947 not just the number.

@locutus2
Copy link
Member

@vondele
My doubled tests so far failed all. I have further ideas but i will test them on top of this PR. So from my viwepoint you can commit this.

@vondele
Copy link
Member

vondele commented May 23, 2020

@locutus2 OK, I'll merge shortly.

@vondele vondele closed this in 81c5885 May 23, 2020
@vondele
Copy link
Member

vondele commented May 23, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants