Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prov/bgq: Fix to matching function on context queues and fifos #2773

Merged
merged 1 commit into from
Mar 2, 2017

Conversation

pkcoff
Copy link
Contributor

@pkcoff pkcoff commented Mar 2, 2017

There was a bug where if the source address was FI_ADDR_UNSPEC the context matching function
used for processing queues and fifos did not look at the tag and successfully
matched, resulting in hangs around MPI_Recv. The logic was changed to always look at
both the tag and source addr when making a match.

Signed-off-by: Paul Coffman pcoffman@anl.gov

…_ADDR_UNSPEC

There was a bug where if the source address was FI_ADDR_UNSPEC the context matching function
used for processing queues and fifos did not look at the tag and successfully
matched, resulting in hangs around MPI_Recv.  The logic was changed to always look at
both the tag and source addr when making a match.

Signed-off-by: Paul Coffman <pcoffman@anl.gov>
Copy link
Contributor

@mblockso mblockso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed with Paul. This new code fixes other application problems as well.

@shefty shefty merged commit 37ef675 into ofiwg:master Mar 2, 2017
@shefty
Copy link
Member

shefty commented Mar 2, 2017

I added @pkcoff as a writer to this repo. Paul, you should be able to merge your own changes to the bgq provider now. We only ask that you let us know if any patches touch the code outside of the provider. Thanks!

@pkcoff
Copy link
Contributor Author

pkcoff commented Mar 2, 2017

OK thanks Sean sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants