prov/util: store hmem_data in ofi_mr_map #8826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure is Azure mirror issue. |
wzamazon
reviewed
Apr 19, 2023
prov/util/src/util_mr_map.c
Outdated
| @@ -257,9 +257,11 @@ void ofi_mr_update_attr(uint32_t user_version, uint64_t caps, | |||
| if (caps & FI_HMEM) { | |||
| cur_abi_attr->iface = user_attr->iface; | |||
| cur_abi_attr->device = user_attr->device; | |||
| cur_abi_attr->hmem_data = user_attr->hmem_data; | |||
There was a problem hiding this comment.
I think you need to check version here. Only when user_version >= 1.19, can you access user_attr->hmem_data.
There was a problem hiding this comment.
It that necessary(or does it work that way)? hmem_data is defined in fi_domain.h and we shouldn't expect a version mismatch between these files right?
There was a problem hiding this comment.
You have to deal with compiled apps which may be against the older header.
There was a problem hiding this comment.
I see. That makes sense. Good catch!
There was a problem hiding this comment.
@wzamazon Do you have other comments?
wenduwan
force-pushed
the
store_hmem_data
branch
3 times, most recently
from
ac8ae0b
to
030fb89
Compare
Store hmem_data in ofi_mr_map such that it can be retrieved later Signed-off-by: Wenduo Wang <wenduwan@amazon.com>
wenduwan
force-pushed
the
store_hmem_data
branch
from
030fb89
to
163058c
Compare
wenduwan
commented
Apr 19, 2023
shefty
approved these changes
Apr 19, 2023
aingerson
approved these changes
Apr 19, 2023
wzamazon
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store hmem_data in ofi_mr_map such that it can be retrieved later