fix: do not fold Set-Cookie values into a single header, per RFC6265 #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1027 +/- ##
==========================================
+ Coverage 72.20% 72.23% +0.02%
==========================================
Files 192 192
Lines 14991 15003 +12
==========================================
+ Hits 10825 10837 +12
Misses 3631 3631
Partials 535 535
☔ View full report in Codecov by Sentry. |
This commit adds a special case for encoding Set-Cookie headers in responses.
Specifically, it prevents `headerParamEncoder` from folding multiple header
values into a single header value with a comma separator, as per RFC6265:
Origin servers SHOULD NOT fold multiple Set-Cookie header fields into
a single header field. The usual mechanism for folding HTTP headers
fields (i.e., as defined in [RFC2616]) might change the semantics of
the Set-Cookie header field because the %x2C (",") character is used
by Set-Cookie in a way that conflicts with such folding.
The comma mentioned by the RFC appears when using a cookie with an expiry
timestamp, because the timestamp format uses a comma after the day-of-week.
shadowspore
reviewed
Sep 7, 2023
tdakkota
approved these changes
Sep 7, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a special case for encoding
Set-Cookieheaders in responses. Specifically, it preventsheaderParamEncoderfrom folding multiple header values into a single header value using a comma separator, as per RFC6265:The comma mentioned by the RFC appears when using a cookie with an expiry timestamp, because the recommended timestamp format (see RFC2616 section 3.3.1) uses a comma after the day-of-week.
/cc @ezzatron