Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): use Radix tree based router #103

Merged
merged 8 commits into from
Jan 6, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Jan 5, 2022

Fixes #103.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #103 (6db4831) into main (d32b505) will decrease coverage by 0.09%.
The diff coverage is 70.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   71.70%   71.60%   -0.10%     
==========================================
  Files          70       72       +2     
  Lines        4068     4209     +141     
==========================================
+ Hits         2917     3014      +97     
- Misses        966      998      +32     
- Partials      185      197      +12     
Impacted Files Coverage Δ
gen/write.go 84.31% <ø> (ø)
internal/ir/operation.go 44.44% <ø> (ø)
gen/router.go 41.37% <40.00%> (-29.39%) ⬇️
gen/route_tree.go 75.29% <75.29%> (ø)
gen/route_node.go 78.74% <78.74%> (ø)
gen/gen_operation.go 92.85% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32b505...6db4831. Read the comment docs.

@tdakkota tdakkota marked this pull request as ready for review January 5, 2022 23:43
@ernado ernado merged commit f1b9f18 into ogen-go:main Jan 6, 2022
@tdakkota tdakkota deleted the feat/radix-router branch January 6, 2022 11:54
@tdakkota tdakkota linked an issue Jan 6, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(router): complex parameters are not supported
2 participants