Allow different tls implementations with cargo features #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try to fix #53 and #21
It uses different features to allow the user to choose a tls implementation. For example, all of the following work:
When using
rustls
ornativetls_vendored
, we can compile dog using musl:--features with_tls,with_rustls
is supported currently, but maybe we should not support this combination at the moment, because of rustls/rustls#281 briansmith/webpki#54 rustls/rustls#184 This means for this to work you'd have to use a valid dns name as a dns server:With an ip address for dns server:
But it works with nativetls:
DNS over HTTPS works with rustls though:
--all-features
is supported as per https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features To not complicate builds etc.