-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more icons - change default icon for videos and PHP #1100
Open
Babkock
wants to merge
8
commits into
ogham:master
Choose a base branch
from
Babkock:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can I get some feedback on this? It's been a couple months now. |
E.g. More specific folders icon |
I think it's okay when is in coming this updated version? |
This was referenced Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, and thank you for your time. I have added quite a bit of icons to the project. I hope it's okay I changed the default icon for videos from the camera to the film strip, and I made the PHP icon the elephant. Please review my suggestions and tell me what you think. I am not attached to any ideas, so if you would like me to change or revert something, please tell me.
Things I've added:
.ssh
,.pub
,.key
,authorized_keys
,known_hosts
.gpg
,.kbx
,.asc
.asm
,.s
,a.out
), object files (.o
,.so
,.a
), and linker script (.ld
).doom.d
,.emacs.d
,init.el
,config.el
,custom.el
,packages.el
.el
,.elc
,.org
.bin
,.elf
.sublime-session
and.sublime-package
/etc
such aspasswd
,sudoers
,groups
,shells
, etc.Desktop
,Downloads
,Pictures
, etc.Thank you for your time.