-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #393: add flag to dereference links #1136
Open
agrzeslak
wants to merge
7
commits into
ogham:master
Choose a base branch
from
agrzeslak:deref_links
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `-X`/`--dereference` flags which are used to enable dereferencing through symbolic links, similar to ls's `-L`. Added the `link_target_recurse` method in order to recursively call the existing `link_target` method to get the final target at the end of the chain of links. In order to appropriately display the final output and play nicely with existing functionality, a `deref_links` variable has been added to a few places such that it can be propagated until the time it is needed during rendering. Following commits will use this information to display dereferenced information.
agrzeslak
changed the title
Implement 393: dereferencing links.
Fix #393: add option to dereference symlinks.
Oct 18, 2022
agrzeslak
changed the title
Fix #393: add option to dereference symlinks.
Fix #393: add option to dereference links.
Oct 18, 2022
agrzeslak
changed the title
Fix #393: add option to dereference links.
Fix #393: add option to dereference links
Oct 18, 2022
agrzeslak
changed the title
Fix #393: add option to dereference links
Fix #393: add flag to dereference links
Oct 18, 2022
Updates? This seems like a good feature to bring it more in parity with ls |
I too would find this useful. Anything blocking this (beyond the merge conflicts)? |
This was referenced Jul 29, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #393
There is currently no equivalent to
ls
's-L
/--dereference
flag. This is often undesirable, as it is rare that a user is interested in the details of the link itself. As such, the-X
/--dereference
flag has been added which implements this functionality. I have chosen-X
as-L
was already taken, and in my mind-X
was similar to "across", in the sense that you are traversing "across" the link. The similar-H
/--dereference-command-line
flag fromls
has also not been implemented in this PR, however it should be straightforward to add, and I may add it to this PR if I have some additional time or it is requested. I am more than happy to accommodate other suggestions, or change my implementation in any way that would be more acceptable to the maintainers.Output without the
-X
flag (identical to before this PR):Output with the
-X
flag (links are now dereferenced):Output when using the analogous
-L
flag withinls
: