Make sort more consistent accross uses and flags #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, files were sorted twice, which in most cases is harmless. But when two files are determined equal, their order is unchanged (because the sort is stable). With `--reverse`, equal elements order, which wasn’t changed by the sort, were reversed twice (unchanged). Also, command lines arguments are now sorted by their path.
|
This branch has conflicts that must be resolved |
This was referenced Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #863
Fix #1030
In some cases, files were sorted twice, which in most cases is harmless.
But when two files are determined equal, their order is unchanged (because the sort is stable).
With
--reverse, equal elements order, which wasn’t changed by the sort, were reversed twice (unchanged).Also, command lines arguments are now sorted by their path.
I still need to check the xtests to see if anything’s wrong with my changes, and update the tests that needs it.