Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support SET NAMES 'utf8' statement #140

Merged
merged 1 commit into from
Jan 8, 2024
Merged

feat: support SET NAMES 'utf8' statement #140

merged 1 commit into from
Jan 8, 2024

Conversation

knixeur
Copy link
Contributor

@knixeur knixeur commented Sep 20, 2023

I blindly added support for SET NAMES 'utf8' which is issued by some ORMs.
Let me know if something is missing/needs to be changed.

@knixeur knixeur mentioned this pull request Sep 20, 2023
Closed
@knixeur
Copy link
Contributor Author

knixeur commented Sep 20, 2023 •
edited
Loading

I wonder if it should be a case of simplestatements_set_simple as it belongs to that pattern https://www.postgresql.org/docs/current/sql-set.html This is incorrect, SET expects either TO or = after the name, SET NAMES does not have any of that and it's even mentioned as an exception below

Besides the configuration parameters documented in Chapter 20, there are a few that can only be adjusted using the SET command or that have a special syntax:

@oguimbal oguimbal merged commit 9ad9c22 into oguimbal:master Jan 8, 2024
@oguimbal
Copy link
Owner

oguimbal commented Jan 8, 2024

Released as pgsql-ast-parser@11.2.0 sorry to have missed that, I've been very busy

@oguimbal oguimbal mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguimbal oguimbal oguimbal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knixeur @oguimbal