Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to even newer OMF plugin structure #3

Merged
merged 1 commit into from
Dec 18, 2015
Merged

Update to even newer OMF plugin structure #3

merged 1 commit into from
Dec 18, 2015

Conversation

sagebind
Copy link
Member

Updates the package to the even newer OMF plugin structure, utilizing function autoloading for startup speed.

Also now uses the core available utility to check for existing Composer commands, which also fixes junk output when it does not exist.

else if test -n "$COMPOSER_BIN"
eval "$COMPOSER_BIN" $argv;
else
echo "Please install composer.phar to your PATH. Or use \"composer_install\" to install Composer to current directory."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's composer.install, but I think we should leave it named composer_install.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okieday then. Will fix.

@sagebind
Copy link
Member Author

Squashed the commits. Ping @derekstavis

@derekstavis
Copy link
Member

A big 👍

@bpinto
Copy link
Member

bpinto commented Dec 18, 2015

Thanks @CoderStephen !

bpinto added a commit that referenced this pull request Dec 18, 2015
Update to even newer OMF plugin structure
@bpinto bpinto merged commit 10aa5ad into oh-my-fish:master Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants