Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made ip_no mandatory in ConsultationForm #2387

Merged
merged 2 commits into from
May 17, 2022
Merged

Made ip_no mandatory in ConsultationForm #2387

merged 2 commits into from
May 17, 2022

Conversation

khavinshankar
Copy link
Member

Fixes #2384

image

@khavinshankar khavinshankar requested a review from a team May 17, 2022 08:50
@@ -820,7 +827,7 @@ export const ConsultationForm = (props: any) => {
</div>

<div id="ip_no-div">
<InputLabel id="refered-label">IP number</InputLabel>
<InputLabel id="refered-label">IP number*</InputLabel>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@developedBySJ I did think of that, but do required attribute help with user friendly message?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar What do you mean by user-friendly message?

@nihal467
Copy link
Member

@khavinshankar @developedBySJ @gigincg is it good for testing ?

@nihal467 nihal467 added question Further information is requested and removed needs testing labels May 17, 2022
@khavinshankar khavinshankar added needs testing and removed question Further information is requested labels May 17, 2022
@khavinshankar
Copy link
Member Author

@nihal467 yes it is ready for testing now

@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit d779e60 into develop May 17, 2022
@khavinshankar khavinshankar deleted the fix#2384 branch November 13, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IP Number : Mandatory field
4 participants