Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store Asset details URL in QR code #3551

Closed
wants to merge 5 commits into from

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 7, 2022

Related issue: ohcnetwork/10bedicu#82
Blocking PR: ohcnetwork/dashboard#205

This PR modifies the data stored in the QR code generated on Asset page. The QR now stores the asset details page's url for the particular asset displayed on the care dashboard.

The QR when scanned externally should now link to a page where the user can view the details of the asset publicly.
If the QR is scanned from within the care platform, it redirects to the asset's page just like before.

Asset page on care_fe:
image

Asset QR scanned from an external scanner:
image

Asset QR scanned from "Scan Asset QR" page in care_fe:

Redirects to the asset's page
image

@Ashesh3 Ashesh3 requested a review from a team September 7, 2022 06:41
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 7, 2022 06:41
@netlify
Copy link

netlify bot commented Sep 7, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c6f564f
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63343386482c3e0008553891
😎 Deploy Preview https://deploy-preview-3551--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ashesh3 Ashesh3 added the blocked label Sep 7, 2022
@mathew-alex mathew-alex added the merge conflict pull requests with merge conflict label Sep 28, 2022
@mathew-alex
Copy link
Contributor

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@Ashesh3 Ashesh3 removed the merge conflict pull requests with merge conflict label Sep 28, 2022
@nihal467
Copy link
Member

nihal467 commented Oct 5, 2022

@Ashesh3 there is an issue with PR, connect with @gigincg to discuss it

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 10, 2022

No longer required.

@Ashesh3 Ashesh3 closed this Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants