Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show asset import progress #6400

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Show asset import progress #6400

merged 2 commits into from
Oct 5, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 5, 2023

WHAT

🤖 Generated by Copilot at 5f4585a

This pull request enhances the asset import feature by adding SelectFormField for location selection, validating the location input, and showing appropriate errors and messages. It also resolves some UI and state bugs in AssetImportModal.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 5f4585a

  • Replace the SelectMenuV2 component with the SelectFormField component for selecting the location for asset import in AssetImportModal.tsx (link, link, link)
  • Add validation and error handling for the location field using the errors state and show an error message if the location is not selected (link, link)
  • Add a loading indicator for the locations data using the locationsLoading state and the setLocationsLoading function (link, link, link)
  • Change the logic for updating the preview state after importing each asset to use a functional update instead of a direct mutation (link)
  • Change the logic for handling the success and failure cases of the import process to show different notifications and actions (link)

@Ashesh3 Ashesh3 requested a review from a team October 5, 2023 06:56
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 5, 2023 06:56
@Ashesh3 Ashesh3 requested a review from gigincg October 5, 2023 06:56
@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bd95384
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/651e6258b8d0b30008f2ab45
😎 Deploy Preview https://deploy-preview-6400--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 7:15am

@nihal467
Copy link
Member

nihal467 commented Oct 5, 2023

LGTM

@cypress
Copy link

cypress bot commented Oct 5, 2023

1 failed test on run #1362 ↗︎

1 77 0 0 Flakiness 0

Details:

Show asset import progress
Project: CARE Commit: 5f4585afc2
Status: Failed Duration: 02:50 💡
Started: Oct 5, 2023 7:00 AM Ended: Oct 5, 2023 7:03 AM
Failed  cypress/e2e/assets_spec/asset_homepage.cy.ts • 1 failed test

View Output Video

Test Artifacts
Asset Tab > Import new asset Test Replay Output Screenshots

Review all test suite changes for PR #6400 ↗︎

@khavinshankar khavinshankar merged commit 8473f35 into develop Oct 5, 2023
29 checks passed
@khavinshankar khavinshankar deleted the asset-import-progress branch October 5, 2023 07:19
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset import feature minor enhancement
3 participants