You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request enhances the asset import feature by adding SelectFormField for location selection, validating the location input, and showing appropriate errors and messages. It also resolves some UI and state bugs in AssetImportModal.tsx.
Replace the SelectMenuV2 component with the SelectFormField component for selecting the location for asset import in AssetImportModal.tsx (link, link, link)
Add validation and error handling for the location field using the errors state and show an error message if the location is not selected (link, link)
Add a loading indicator for the locations data using the locationsLoading state and the setLocationsLoading function (link, link, link)
Change the logic for updating the preview state after importing each asset to use a functional update instead of a direct mutation (link)
Change the logic for handling the success and failure cases of the import process to show different notifications and actions (link)
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 5f4585a
This pull request enhances the asset import feature by adding
SelectFormField
for location selection, validating the location input, and showing appropriate errors and messages. It also resolves some UI and state bugs inAssetImportModal.tsx
.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at 5f4585a
SelectMenuV2
component with theSelectFormField
component for selecting the location for asset import inAssetImportModal.tsx
(link, link, link)errors
state and show an error message if the location is not selected (link, link)locationsLoading
state and thesetLocationsLoading
function (link, link, link)preview
state after importing each asset to use a functional update instead of a direct mutation (link)