Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Flaky Cypress Test in user tab #6864

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fixed Flaky Cypress Test in user tab #6864

merged 1 commit into from
Dec 14, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Dec 14, 2023

WHAT

🤖[deprecated] Generated by Copilot at 2b7c488

Modified the verifyMultipleBadgesWithSameId method in UserSearch.ts to use a different logic for checking user views. This was done to fix a failing test case.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 2b7c488

  • Modify the logic for verifying user views with multiple badges (link)

@nihal467 nihal467 requested a review from a team as a code owner December 14, 2023 09:08
Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2b7c488
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/657ac60d07d83d000866f9fd
😎 Deploy Preview https://deploy-preview-6864--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 9:08am

Copy link

cypress bot commented Dec 14, 2023

Passing run #1718 ↗︎

0 91 0 0 Flakiness 0

Details:

Fixed Flaky Cypress Test in user tab
Project: CARE Commit: 2b7c488d35
Status: Passed Duration: 02:22 💡
Started: Dec 14, 2023 9:12 AM Ended: Dec 14, 2023 9:14 AM

Review all test suite changes for PR #6864 ↗︎

@khavinshankar khavinshankar merged commit 881e247 into develop Dec 14, 2023
41 of 43 checks passed
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix-flakytest branch December 14, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants