Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Total Discharge patients Number is made Visible for all user type #7593

Conversation

r-nikhilkumar
Copy link
Contributor

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@r-nikhilkumar r-nikhilkumar requested a review from a team as a code owner April 13, 2024 12:00
Copy link

vercel bot commented Apr 13, 2024

@r-nikhilkumar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a948af5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6635288dbcf11f000800141b
😎 Deploy Preview https://deploy-preview-7593--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@r-nikhilkumar
image

  • In your current deploy preview, it is not communicating the total number of discharged patients effectively. Think of a better consistent UI, and build a mockup, discuss it during the call. For example, in the screenshot above, the total count is shown across the platform.

@r-nikhilkumar
Copy link
Contributor Author

@nihal467 It won't show any number if there's no discharged patient available there, and in the current ui, the number will be visible once you will go in discharged section, in the screenshot you are in live section, I discussed with mentor then after I implemented this.

@r-nikhilkumar
Copy link
Contributor Author

@aparnacoronasafe, @gigincg @nihal467
Here are some examples of UI, as @nihal467 said in today's meeting to share these three UIs, kindly have a look and check

image
image-2
image-1

@aparnacoronasafe
Copy link
Member

Design to be kept consistent with patient live listing

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 24, 2024
Copy link

👋 Hi, @r-nikhilkumar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@r-nikhilkumar
Copy link
Contributor Author

@aparnacoronasafe so which design should I implement?

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit b46c789
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/66291f0ca6b1140008960980

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 24, 2024
@rithviknishad rithviknishad added needs testing and removed changes required Deploy-Failed Deplyment is not showing preview discussion required merge conflict pull requests with merge conflict needs testing labels Apr 25, 2024
@rithviknishad
Copy link
Member

so which design should I implement?

@r-nikhilkumar As mentioned, designs to be kept consistent like how we have in the Live patients list page.

None of the designs shown above are consistent with the live patients list page.

Copy link

github-actions bot commented May 3, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 3, 2024
@github-actions github-actions bot removed the stale label May 4, 2024
@rithviknishad
Copy link
Member

rithviknishad commented May 6, 2024

Closing as no activity and completed in #7744

@r-nikhilkumar r-nikhilkumar deleted the Fixes#7570_Total_Discharge_patients_Number_made_Visible branch May 6, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total Discharge patients Number to be made Visible for all user type
5 participants