Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected Spelling mistake of daily rounds fields: ventilator_fi02 to ventilator_fio2 in Frontend #8241 #8268

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Corrected Spelling mistake of daily rounds fields: ventilator_fi02 to ventilator_fio2 in Frontend #8241 #8268

merged 2 commits into from
Aug 22, 2024

Conversation

SagarSharma2809
Copy link
Contributor

@SagarSharma2809 SagarSharma2809 commented Aug 7, 2024 •
edited by rithviknishad
Loading

Required Backends

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@SagarSharma2809
Corrected Spelling mistake of daily rounds fields: ventilator_fi02 to…
e0aaac0 
… ventilator_fio2 in frontend types definitions and usages
@SagarSharma2809 SagarSharma2809 requested a review from a team as a code owner August 7, 2024 15:52
@vercel Vercel
Copy link

vercel bot commented Aug 7, 2024

@SagarSharma2809 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

@netlify Netlify
Copy link

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 176bcd5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/66c5e3c157514c000860dcb2
😎 Deploy Preview https://deploy-preview-8268--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Aug 8, 2024

@SagarSharma2809 can you make the requested changes in the related backend PR ohcnetwork/care#2345 ,

@nihal467 nihal467 added the waiting for related PR a co-related detail PR is under construction label Aug 8, 2024
@SagarSharma2809
Copy link
Contributor Author

Yes @nihal467

@nihal467
Copy link
Member

nihal467 commented Aug 13, 2024 •
edited
Loading

@rithviknishad assigning you the PR, to create relevant backend changes, post fixing it, mark it as need testing

@rithviknishad rithviknishad mentioned this pull request Aug 13, 2024
Merged
2 tasks
@rithviknishad rithviknishad added needs testing Backend and removed changes required waiting for related PR a co-related detail PR is under construction labels Aug 13, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 14, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @SagarSharma2809,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Aug 14, 2024
@github-actions GitHub Actions
Copy link

👋 Hi, @SagarSharma2809,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Aug 14, 2024
@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Aug 21, 2024
@rithviknishad rithviknishad added P1 breaking issue or vital feature and removed Backend waiting for backend labels Aug 21, 2024
@khavinshankar khavinshankar merged commit 48a0365 into ohcnetwork:develop Aug 22, 2024
29 of 30 checks passed
@github-actions GitHub Actions
Copy link

@rithviknishad @SagarSharma2809 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

UdaySagar-Git pushed a commit to UdaySagar-Git/care_fe that referenced this pull request Aug 23, 2024
@SagarSharma2809 @rithviknishad @UdaySagar-Git
Corrected Spelling mistake of daily rounds fields: ventilator_fi02 to…
9d2640d 
… ventilator_fio2 in frontend types definitions and usages (ohcnetwork#8268)

Co-authored-by: rithviknishad <mail@rithviknishad.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees

@rithviknishad rithviknishad

Labels
needs review P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct spelling mistake of daily round field: ventilator_fi02 to ventilator_fio2
4 participants
@SagarSharma2809 @nihal467 @rithviknishad @khavinshankar