Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert index page and add selector to state #191

Merged
merged 4 commits into from
Apr 29, 2021
Merged

revert index page and add selector to state #191

merged 4 commits into from
Apr 29, 2021

Conversation

Deep-Codes
Copy link
Contributor

@Deep-Codes Deep-Codes commented Apr 29, 2021 •
edited
Loading

⚠️ DON'T MERGE IT ⚠️

@Deep-Codes Deep-Codes requested a review from a team April 29, 2021 12:29
@Deep-Codes Deep-Codes self-assigned this Apr 29, 2021
@vercel
Copy link

vercel bot commented Apr 29, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/coronasafe/life/G7pKK7UG8t4Bkd3gC7bcvAyU1Mxs
✅ Preview: https://life-git-refactor-index-coronasafe.vercel.app

@Deep-Codes Deep-Codes marked this pull request as draft April 29, 2021 12:29
@ProCode2
Copy link
Contributor

ProCode2 commented Apr 29, 2021 •
edited
Loading

Showing live tweet results for "" (Fixed)
Screenshot 2021-04-29 at 6 11 18 PM

@Deep-Codes
Copy link
Contributor Author

Shows showing live tweet results for ""
Screenshot 2021-04-29 at 6 11 18 PM

it's updated in the newest preview

@ProCode2
Copy link
Contributor

Perfect!

@shrihari689 shrihari689 marked this pull request as ready for review April 29, 2021 12:45
@Deep-Codes
Copy link
Contributor Author

@shrihari689 I don't see any problems.

@ProCode2
Copy link
Contributor

Give the Result and Twitter tabs a fixed height so that the footer doesn't jump when changing the tab

@Deep-Codes
Copy link
Contributor Author

Deep-Codes commented Apr 29, 2021 •
edited
Loading

Give the Result and Twitter tabs a fixed height so that the footer doesn't jump when changing the tab

On it I was wondering why that happens

@shrihari689 do it idk where that is

@shrihari689
Copy link
Contributor

On it 🔥

@shrihari689
Copy link
Contributor

shrihari689 commented Apr 29, 2021 •
edited
Loading

Couldn't find a workaround as well 😪

Can we skip this as for now?

@Deep-Codes
Copy link
Contributor Author

Yes let's just get this running

@shrihari689 shrihari689 merged commit 8e626bf into main Apr 29, 2021
@ProCode2
Copy link
Contributor

just had to add a min height to a parent div 😅

@shrihari689 shrihari689 deleted the refactor-index branch May 3, 2021 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@shrihari689 shrihari689

@Deep-Codes Deep-Codes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deep-Codes @ProCode2 @shrihari689