Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated oracleTempSchema with tempEmulationSchema #28

Closed
schuemie opened this issue Jan 19, 2022 · 1 comment · Fixed by #29
Closed

Replace deprecated oracleTempSchema with tempEmulationSchema #28

schuemie opened this issue Jan 19, 2022 · 1 comment · Fixed by #29

Comments

@schuemie
Copy link
Member

Several functions like 'getConceptCodeDetails()' have an oracleTempSchema argument. First of all, please make sure this is really necessary. Are these functions using temp tables? Second, oracleTempSchema has been deprecated across HADES. Please use `tempEmulationSchema' instead, and set the default value like this.

@mdlavallee92
Copy link
Collaborator

At first, I did a replace of all oracleTempSchema but good point this probably doesn't need a temp schema since it is just querying off the vocabulary schema into an R data.frame. I will remove that option from the function.

Issue will close when I merge the pull request.

mdlavallee92 added a commit that referenced this issue Jan 19, 2022
Address Issue #27 and #28 updating documentation and minor fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants