Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect URL to one source Synpuf file #65

Closed
schuemie opened this issue Sep 14, 2021 · 5 comments · Fixed by #72
Closed

Incorrect URL to one source Synpuf file #65

schuemie opened this issue Sep 14, 2021 · 5 comments · Fixed by #72

Comments

@schuemie
Copy link
Member

On the CMS website, the 2010 Beneficiary Summary file of sample 1 has an incorrect name. It is called DE1_0_2010_Beneficiary_Summary_File_Sample_20.zip, but the Python script expects it to be called DE1_0_2010_Beneficiary_Summary_File_Sample_1.zip (which would make more sense since it is sample number 1, not 20).

Because of this, the Python script throws an error when trying to download the first sample.

A simple workaround is:

  1. Use the script to download the first sample, and watch it throw the error at the last file.
  2. Manually download and unzip the missing file.
  3. Use the script to download the other 19 samples without issue.

It would be nice if the script was modified to deal with this, but I suspect not many people will be working on this repo anymore.

@jeff-m-sullivan
Copy link
Contributor

I've reached out to ResDAC to ask them about this. Will update here if I get a reply.

@ckrusemd
Copy link

ckrusemd commented Jan 3, 2022

Any news from ResDAC regarding this?

@jeff-m-sullivan
Copy link
Contributor

I've learned that it's not something they maintain. I am trying to figure out who is responsible, but so far no luck.

@schuemie
Copy link
Member Author

schuemie commented Jan 4, 2022

Maybe just implement a workaround in the script?

jeff-m-sullivan added a commit to EntityRisk/ETL-CMS that referenced this issue Jan 4, 2022
ChristopheLambert pushed a commit that referenced this issue Jan 12, 2022
* fix typo NCD -> NDC

* custom URL closes #65
@schuemie
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants