Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add to dependency what to migrate to bundle gem in Ruby 3.4 #915

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

Watson1978
Copy link
Collaborator

@Watson1978 Watson1978 commented Feb 28, 2024

This patch will fix https://github.com/ohler55/oj/actions/runs/7908156404/job/21586745798

Some gems using CI will be changed bundled gem since Ruby 3.4.0. To use bundled gem, it requires to specify the dependency in Gemfile.

Ref. #901

@Watson1978 Watson1978 marked this pull request as draft February 28, 2024 08:10
@Watson1978 Watson1978 changed the title Add mutex_m gem as dependency in rails 6.1 tests Add to dependency what to migrate to bundle gem in Ruby 3.4 Feb 28, 2024
This patch will fix https://github.com/ohler55/oj/actions/runs/7908156404/job/21586745798

The mutex_m gem will be changed bundled gem since Ruby 3.4.0.
To use bundled gem, it requires to specify the dependency in Gemfile.

Ref. ohler55#901
@Watson1978 Watson1978 marked this pull request as ready for review February 28, 2024 08:22
@Watson1978 Watson1978 changed the title Add to dependency what to migrate to bundle gem in Ruby 3.4 CI: Add to dependency what to migrate to bundle gem in Ruby 3.4 Feb 28, 2024
Copy link
Owner

@ohler55 ohler55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ohler55 ohler55 merged commit 8302922 into ohler55:develop Feb 28, 2024
42 checks passed
@Watson1978 Watson1978 deleted the mutex_m branch February 29, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants