Fix issues with Node.isOptional() typings #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Node.isOptional is a function returning a boolean, but the typings show it as a property, not a method. Changing it to a method would help many TypeScript users, and I'm running into issues using this function myself.
|
I've just published v16.3.3 containing this fix. |
|
Thank you! |
|
I just tried to download the latest version (v16.3.3) and it doesn't have the fix. Can you double-check that you've uploaded it? |
|
My bad. I forgot that this file is generated from index.d.ts.template — so as soon as I ran the release, it overwrote the changes. I just landed a proper fix and did a new release (v16.3.4). Thanks for pointing out the mistake! |
|
Oops. Sorry about that! Thanks for patching it properly and being so quick to respond. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Node.isOptional is a function returning a boolean, but the typings show it as a property, not a method. Changing it to a method would help many TypeScript users, and I'm running into issues using this function myself.