Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/bashmarks: Fixed conflict with d alias #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kreyren
Copy link
Contributor

@Kreyren Kreyren commented Aug 15, 2019

Fixes: #63

@Kreyren Kreyren requested a review from nntoan August 15, 2019 12:58
@Kreyren Kreyren self-assigned this Aug 15, 2019
@Kreyren Kreyren added the P3 - Normal Priority 3 - Normal label Aug 15, 2019
@nntoan nntoan added the bug-fix Issues about fixing bugs label Feb 17, 2020
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the proper fix. If we change the alias, it becomes inconsistent with the upstream https://github.com/huyng/bashmarks. Unless the upstream also changes the name at the same time, this change will confuse users.

By the way, I again found that the copyright notice of the upstream has been rewritten in this script. I think we need to check the copyright of all the plugins and themes that have the corresponding upstream.

@akinomyoga akinomyoga added P4 - Under Normal Priority 4 and removed P3 - Normal Priority 3 - Normal labels Sep 1, 2024
@akinomyoga
Copy link
Contributor

I also lowered the priority of this PR. Our template loads bashmarks by default, so the existing users with the default setup should be familiar with the bashmarks''s drather thandinlib/directories.sh. If either one would be changed, what should be changed is the one in lib/directories.sh. The users who would prefer dinlib/directories.shshould already removedbashmarks` from the plugin array or adjust the setup as they like, so they should be fine as is.

A possible problem is that the new users don't have access to d in lib/directories.sh. We may give a new name to the alias in lib/directories.sh while keeping d. We need to keep d in lib/directories.sh because otherwise, the existing users using them by removing bashmarks from the plugin array would be affected.

By the way, I again found that the copyright notice of the upstream has been rewritten in this script. I think we need to check the copyright of all the plugins and themes that have the corresponding upstream.

This was solved in 0ff46f6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix Issues about fixing bugs P4 - Under Normal Priority 4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias conflict between bashmarks.sh and directories.sh
3 participants