Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong color parameter in glg and other aliases in git plugin #4727

Closed
atk91 opened this issue Dec 25, 2015 · 0 comments
Closed

Wrong color parameter in glg and other aliases in git plugin #4727

atk91 opened this issue Dec 25, 2015 · 0 comments
Labels
Topic: alias Pull Request or issue regarding aliases

Comments

@atk91
Copy link
Contributor

atk91 commented Dec 25, 2015

In my ~/.gitconfig I have

[color]
    pager = no

And I use vim as pager. It has built-in git log highlighting, so the output of git log looks like this:
1

However, glg output looks weird:
2

This happens because glg alias expands to git log --stat --color -p and --color param prevents color.ui = no in my ~/.gitconfig from working.

I think --color should be removed from all git log aliases in order to let user decide in his ~/.gitconfig whether to use colorized git log output or not.

@atk91 atk91 changed the title Wrong color parameter in glg & other aliases in git plugin Wrong color parameter in glg and other aliases in git plugin Dec 25, 2015
@mcornella mcornella added the Topic: alias Pull Request or issue regarding aliases label Mar 30, 2016
rsrchboy added a commit to rsrchboy/oh-my-zsh that referenced this issue Apr 11, 2016
* remotes/upstream/master: (22 commits)
  Use `grep -q` for silent behavior
  Fix logic of bureau_git_status function
  Add git user profile functions for prompt display
  localization support for clock in candy theme
  Add 'asdf' plugin
  Update 'tm' function to take multiple files on the command-line
  Update README.markdown
  Remove "Mac" from "Mac OS X"
  Optimize the ys.zsh-theme make it simpler
  [feature/npm-outdated] - add alias for "npm outdated" to check outdated npm modules
  Update GitHub download URLs in README
  Minor README fixes
  Add missing alias to README of bundler plugin
  Closes ohmyzsh#4727
  Avoid using "PREFIX" that cause nvm to complain about.
  Changed env based sf2 shortcuts to sfdev & sfprod
  Added environment based shortcuts in symfony2 plugin
  Fix checkmark for clean repo in bureau theme
  Added a short description of the plugin
  Update seach parameter
  ...
foobacca pushed a commit to foobacca/oh-my-zsh that referenced this issue Apr 18, 2016
* origin/master:
  Moved git.io url to https
  Use `grep -q` for silent behavior
  Fix logic of bureau_git_status function
  Add git user profile functions for prompt display
  localization support for clock in candy theme
  Add 'asdf' plugin
  Update 'tm' function to take multiple files on the command-line
  Add missing alias to README of bundler plugin
  Closes ohmyzsh#4727
  Avoid using "PREFIX" that cause nvm to complain about.
  Changed env based sf2 shortcuts to sfdev & sfprod
  Added environment based shortcuts in symfony2 plugin
  Fix checkmark for clean repo in bureau theme
  Added a short description of the plugin
  Update seach parameter
  Proper handling of tags
  Geeknote autocomplete and alias
freecastle added a commit to freecastle/oh-my-zsh that referenced this issue May 24, 2016
* 'master' of https://github.com/robbyrussell/oh-my-zsh:
  Use `grep -q` for silent behavior
  Fix logic of bureau_git_status function
  Add git user profile functions for prompt display
  localization support for clock in candy theme
  Add 'asdf' plugin
  Update 'tm' function to take multiple files on the command-line
  Add missing alias to README of bundler plugin
  Closes ohmyzsh#4727
  Avoid using "PREFIX" that cause nvm to complain about.
  Changed env based sf2 shortcuts to sfdev & sfprod
  Added environment based shortcuts in symfony2 plugin
  Fix checkmark for clean repo in bureau theme
  Added a short description of the plugin
  Update seach parameter
  Proper handling of tags
  Geeknote autocomplete and alias
cpfaff pushed a commit to cpfaff/oh-my-zsh that referenced this issue Jun 29, 2016
atsuya pushed a commit to atsuya/oh-my-zsh that referenced this issue Jul 23, 2016
DennisDenuto pushed a commit to DennisDenuto/oh-my-zsh that referenced this issue Oct 29, 2016
jmartindf pushed a commit to jmartindf/oh-my-zsh that referenced this issue Nov 10, 2018
spiliopoulos pushed a commit to spiliopoulos/zsh-config that referenced this issue Jun 17, 2020
Luxcium added a commit to LuxciumProject/ahmyzsh that referenced this issue Sep 20, 2020
https://github.com/ohmyzsh/ohmyzsh/blob/93c837fec8e9fe61509b9dff9e909e84f7ebe32d/plugins/git/git.plugin.zsh#L1-L293

Copyright (c) 2009-2020 Robby Russell and
[contributors](https://github.com/ohmyzsh/ohmyzsh/contributors)

TAnks to those who have contributed to fix those 20+ issues:

ohmyzsh/ohmyzsh#1790
ohmyzsh/ohmyzsh#3535
ohmyzsh/ohmyzsh#3682
ohmyzsh/ohmyzsh#3962
ohmyzsh/ohmyzsh#3972
ohmyzsh/ohmyzsh#3977
ohmyzsh/ohmyzsh#3991
ohmyzsh/ohmyzsh#4085
ohmyzsh/ohmyzsh#4727
ohmyzsh/ohmyzsh#5130
ohmyzsh/ohmyzsh#5179
ohmyzsh/ohmyzsh#5362
ohmyzsh/ohmyzsh#5442
ohmyzsh/ohmyzsh#6329
ohmyzsh/ohmyzsh#6793
ohmyzsh/ohmyzsh#7682
ohmyzsh/ohmyzsh#7716
ohmyzsh/ohmyzsh#7754
ohmyzsh/ohmyzsh#867
ohmyzsh/ohmyzsh#9103
ohmyzsh/ohmyzsh#9114

and those who help develop
theses aliases and function
whith theses Pull 40+ Requests:

ohmyzsh/ohmyzsh#2790
ohmyzsh/ohmyzsh#3167
ohmyzsh/ohmyzsh#4304
ohmyzsh/ohmyzsh#4751
ohmyzsh/ohmyzsh#4830
ohmyzsh/ohmyzsh#4993
ohmyzsh/ohmyzsh#5025
ohmyzsh/ohmyzsh#5178
ohmyzsh/ohmyzsh#5271
ohmyzsh/ohmyzsh#5287
ohmyzsh/ohmyzsh#5306
ohmyzsh/ohmyzsh#5307
ohmyzsh/ohmyzsh#5390
ohmyzsh/ohmyzsh#5417
ohmyzsh/ohmyzsh#5433
ohmyzsh/ohmyzsh#5511
ohmyzsh/ohmyzsh#5591
ohmyzsh/ohmyzsh#5643
ohmyzsh/ohmyzsh#5729
ohmyzsh/ohmyzsh#5844
ohmyzsh/ohmyzsh#5849
ohmyzsh/ohmyzsh#5871
ohmyzsh/ohmyzsh#6006
ohmyzsh/ohmyzsh#6031
ohmyzsh/ohmyzsh#6059
ohmyzsh/ohmyzsh#6079
ohmyzsh/ohmyzsh#6297
ohmyzsh/ohmyzsh#6378
ohmyzsh/ohmyzsh#6789
ohmyzsh/ohmyzsh#6791
ohmyzsh/ohmyzsh#6893
ohmyzsh/ohmyzsh#7064
ohmyzsh/ohmyzsh#7472
ohmyzsh/ohmyzsh#7556
ohmyzsh/ohmyzsh#7629
ohmyzsh/ohmyzsh#7630
ohmyzsh/ohmyzsh#7724
ohmyzsh/ohmyzsh#7841
ohmyzsh/ohmyzsh#8089
ohmyzsh/ohmyzsh#8563
ohmyzsh/ohmyzsh#8617
ohmyzsh/ohmyzsh#8622
ohmyzsh/ohmyzsh#8697
ohmyzsh/ohmyzsh#8902
ohmyzsh/ohmyzsh#8935
ohmyzsh/ohmyzsh#8957
ohmyzsh/ohmyzsh#9049
Signed-off-by: Benjamin Vincent (Luxcium) <luxcium@neb401.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Topic: alias Pull Request or issue regarding aliases
Projects
None yet
Development

No branches or pull requests

2 participants