[git] Alias gsta is broken for git 2.7

[flohw]

Hello there!

I often use gsta alias to stash some modification within a project for later.
After the update this morning, it didn't work anymore.
I think the check on the version number of git is wrong.
I am on git 2.7 wich is considered greater than 2.13 (float number comparisn instead of text) and the alias set is git stash push instead of git stash save.

Why not using only git stash which is cross version compatible ?

Sorry to not be able to provide a PR as I am not that good with zsh tests.

Thaks!

[mcornella]

This was changed in #7486 because parameters past to just git stash weren't the same. I pushed a patch that should again make your alias use save instead. Thanks for reporting

[flohw]

Thank you @mcornella, just pulled and works fine.
Thanks for explanation about alias too.

[brainplot]

@mcornella I think the root of the problem is that you got the comparison terms wrong when you merged the PR. I just realized that. When you use =~ for regex matching, $match contains the whole string, so $match -ge '2.13' will likely perform lexicographic string comparison.
$match[1] contains only what's been captured in the capturing group, resulting in this (after expansion): 2.13 -ge '2.7' and that should work as expected.
I'm pretty sure of this because I tested my solution with hardcoded versions and it worked.
I think this is the proper fix for this issue.

[mcornella]

$match is a single-element array, so it's the same $match[1] than $match (you're confusing it with $MATCH). The conditional should be, is version greater or equal than 2.13, which is [[ 2.7 -ge 2.13 ]], which fails because it's true (the number 2.7, arithmetically, is greater than 2.13).

[brainplot]

Yes, you're right, sorry. I sent a PR with a version that doesn't use awk.
Feel free to accept/reject it :)