Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the character used from powerline #1872

Merged
merged 1 commit into from
Jun 21, 2013

Conversation

gdetrez
Copy link
Contributor

@gdetrez gdetrez commented Jun 6, 2013

In the current version of the font, the fancy glyphs have been moved to the Private Use Area: powerline/powerline#4

The code points have been updated in 53fbfe1

This updates the agnoster theme accordingly.

robbyrussell added a commit that referenced this pull request Jun 21, 2013
Update the character used from powerline
@robbyrussell robbyrussell merged commit 78dba75 into ohmyzsh:master Jun 21, 2013
@dvcrn
Copy link

dvcrn commented Jun 23, 2013

Having some troubles with this.
Updated agnoster theme + patched font, but still can't see the glyphs. OS X with iTerm2 here. Cleared font cache

Screenshot

Am I the only one?

@joshka
Copy link
Contributor

joshka commented Jun 23, 2013

I also have the same issue, definitely caused by this update.

@gdetrez
Copy link
Contributor Author

gdetrez commented Jun 23, 2013

I don't know anything about iTerm or OS X but you can try the following command to see if your font uses the right code points:

echo -e "\xee\x82\xa0\xee\x82\xa1\xee\x82\xa2\xee\x82\xb0\xee\x82\xb1\xee\x82\xb2\xee\x82\xb3"

should print:

screenshot from 2013-06-23 15 30 15

@joshka
Copy link
Contributor

joshka commented Jun 23, 2013

screen shot 2013-06-23 at 11 33 33 pm

What fonts are you using?

The 'patched' fonts from various places including https://github.com/Lokaltog/powerline-fonts do not match these code points.

@gdetrez
Copy link
Contributor Author

gdetrez commented Jun 23, 2013

I'm using PowerlineSymbols.otf directly.

I tried the following test on https://github.com/Lokaltog/powerline-fonts and it looks like they have been updated to the the new code points:

$ find powerline-fonts-master -name "*.[ot]tf" -print0 -exec python -c "from fontTools.ttLib import TTFont ; print '\t', ord(u'\ue0b0') in TTFont('{}')['cmap'].getcmap(3,1).cmap.keys()" \;
./AnonymousPro/Anonymous Pro Bold Italic for Powerline.ttf  True
./AnonymousPro/Anonymous Pro Bold for Powerline.ttf True
./AnonymousPro/Anonymous Pro Italic for Powerline.ttf   True
./AnonymousPro/Anonymous Pro for Powerline.ttf  True
./DejaVuSansMono/DejaVu Sans Mono Bold Oblique for Powerline.ttf    True
./DejaVuSansMono/DejaVu Sans Mono Bold for Powerline.ttf    True
./DejaVuSansMono/DejaVu Sans Mono Oblique for Powerline.ttf True
./DejaVuSansMono/DejaVu Sans Mono for Powerline.ttf True
./DroidSansMono/Droid Sans Mono for Powerline.otf   True
./Inconsolata/Inconsolata for Powerline.otf True
./InconsolataDz/Inconsolata-dz for Powerline.otf    True
./LiberationMono/Liberation Mono Bold Italic for Powerline-fixed.ttf    True
./LiberationMono/Liberation Mono Bold for Powerline-fixed.ttf   True
./LiberationMono/Liberation Mono Italic for Powerline-fixed.ttf True
./LiberationMono/Liberation Mono for Powerline-fixed.ttf    True
./Menlo/Menlo Bold Italic for Powerline.ttf True
./Menlo/Menlo Bold for Powerline.ttf    True
./Menlo/Menlo Italic for Powerline.ttf  True
./Menlo/Menlo Regular for Powerline.ttf True
./Meslo/Meslo LG L DZ Regular for Powerline.otf True
./Meslo/Meslo LG L Regular for Powerline.otf    True
./Meslo/Meslo LG M DZ Regular for Powerline.otf True
./Meslo/Meslo LG M Regular for Powerline.otf    True
./Meslo/Meslo LG S DZ Regular for Powerline.otf True
./Meslo/Meslo LG S Regular for Powerline.otf    True
./SourceCodePro/Source Code Pro Black for Powerline.otf True
./SourceCodePro/Source Code Pro Bold for Powerline.otf  True
./SourceCodePro/Source Code Pro ExtraLight for Powerline.otf    True
./SourceCodePro/Source Code Pro Light for Powerline.otf True
./SourceCodePro/Source Code Pro Medium for Powerline.otf    True
./SourceCodePro/Source Code Pro Regular for Powerline.otf   True
./SourceCodePro/Source Code Pro Semibold for Powerline.otf  True
./UbuntuMono/Ubuntu Mono derivative Powerline Bold Italic.ttf   True
./UbuntuMono/Ubuntu Mono derivative Powerline Bold.ttf  True
./UbuntuMono/Ubuntu Mono derivative Powerline Italic.ttf    True
./UbuntuMono/Ubuntu Mono derivative Powerline.ttf   True

@chuangbo
Copy link

I have this issue too.

@nudelfabrik
Copy link

same here, #1872 broke the fancy icons with agnoster and https://gist.github.com/qrush/1595572

@gdetrez
Copy link
Contributor Author

gdetrez commented Jun 25, 2013

@nudelfabrik the fonts you point to use the old code points, you have to update or patch the font yourself.

@nudelfabrik
Copy link

Ok, searched for another Font, that worked. Thanks @gdetrez

@chuangbo
Copy link

I resolve my problem by purge the old fonts and reinstall. Thanks.

@dvcrn
Copy link

dvcrn commented Jun 26, 2013

What fonts are you using?
Just tried manual patching of some fonts on my system but no success. Still no glyphs

@chuangbo
Copy link

@dabido Menlo from https://github.com/Lokaltog/powerline-fonts. Try purge the old fonts and quit iTerm first.

@chuangbo
Copy link

@dabido And making sure you set both 'Regular Font' and 'Non-ASCII Font' either.

@dvcrn
Copy link

dvcrn commented Jun 26, 2013

All right, here's what I did:

  • Deleted the old font
  • Force cleared my trash bin (rm -rf ~/.Trash/*)
  • Cleared font cache (sudo atsutil databases -remove)
  • Installed new font
  • Set as regular font and non ascii-font

Works fine now, thanks!

@joshka
Copy link
Contributor

joshka commented Jun 27, 2013

Thanks dabido, that works for me

@cchaudier
Copy link

Hello.
I'm on Ubuntu 13.04 with Terminal GNOME v3.6.1.
I have solved the problem with this command lines :

mkdir -p ~/.fonts/ && cd ~/.fonts/ 
wget https://github.com/Lokaltog/powerline/raw/develop/font/PowerlineSymbols.otf
fc-cache -vf ~/.fonts  
mkdir -p ~/.config/fontconfig/conf.d/ && cd ~/.config/fontconfig/conf.d/
wget https://github.com/Lokaltog/powerline/raw/develop/font/10-powerline-symbols.conf

@gdetrez gdetrez deleted the new-powerline-range branch July 19, 2013 11:41
@h0jeZvgoxFepBQ2C
Copy link

I changed my agnoster.theme to SEGMENT_SEPARATOR='⮀' on line 29. works now (was displaying a box before)

@Kaweechelchen
Copy link

@dabido 's post helped me ;)
thx
#1872 (comment)

@HelloGrayson
Copy link

@lichtamberg worked for me thanks (mavericks/iterm2 w menlo patched)

@mad0ba
Copy link

mad0ba commented Dec 31, 2015

For any one having troubles with a broken prompt, follow these instructions https://powerline.readthedocs.org/en/latest/installation/linux.html#fontconfig and it should do the trick. I have to say thanks to @emyller for the solution, thanks man. Ive been on this for hours :) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.