Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few invalid symbols in 'agnoster.zsh-theme' #1906

Closed
hitigon opened this issue Jun 24, 2013 · 111 comments
Closed

A few invalid symbols in 'agnoster.zsh-theme' #1906

hitigon opened this issue Jun 24, 2013 · 111 comments

Comments

@hitigon
Copy link

@hitigon hitigon commented Jun 24, 2013

Like line 29. Please fix it. Thank you.

@wombat2k
Copy link

@wombat2k wombat2k commented Jun 24, 2013

Just to be clear, this is what it now looks like in iTerm 2:

screen shot 2013-06-24 at 2 05 44 pm

I suppose it could be normal, but it seems like an odd choice

@stianeikeland
Copy link

@stianeikeland stianeikeland commented Jun 24, 2013

Commit 97849bd seems to be the cause, reverting agnoster.theme to d6a36b1 fixes it for me.

It looks like they have updated the font upstream. A bit annoying, but hopefully grabbing a updated powerline font will fix it.

@hitigon
Copy link
Author

@hitigon hitigon commented Jun 24, 2013

@wombat2k Thanks
@stianeikeland You are right. I just replaced the symbol on line 29 with the old one, but others are ignored since I do not use hg.

@damianball
Copy link

@damianball damianball commented Jun 25, 2013

I am also seeing this issue. Reverting to d6a36b1 fixes it for me as well. I guess I'll look for an updated powerline font as @stianeikeland suggests... or build one.

Update: I just noticed there are still issues in vim

iTerm2: Build 1.0.0.20130622
Mac OS X: 10.8.4 Build 12E55

screen shot 2013-06-24 at 6 45 48 pm

@it-ony
Copy link

@it-ony it-ony commented Jun 25, 2013

Works for me as well. Thanks

cd ~/.oh-my-zsh/themes/
git checkout  d6a36b1 agnoster.zsh-theme
@jmatcuk
Copy link

@jmatcuk jmatcuk commented Jun 25, 2013

I had the same issue with the fonts and simply edited the theme to re-insert the special characters. Is there a new Powerline font that resolves this issue?

@mariofink
Copy link

@mariofink mariofink commented Jun 26, 2013

Thanks @it-ony. Works perfectly as a short-time fix.

@stianeikeland
Copy link

@stianeikeland stianeikeland commented Jun 26, 2013

I tried the newest readily made fonts from https://github.com/Lokaltog/powerline-fonts , but no dice.
Anyone tried to patching fonts themselves using https://github.com/Lokaltog/powerline ?

@schickling
Copy link

@schickling schickling commented Jun 26, 2013

Same here

@chrw
Copy link
Contributor

@chrw chrw commented Jun 26, 2013

Same issue here. Reverting to d6a36b1 fixed the problem for now.

@wildjcrt
Copy link

@wildjcrt wildjcrt commented Jun 28, 2013

Met this after upgraded. Thanks @it-ony

@stianeikeland
Copy link

@stianeikeland stianeikeland commented Jun 28, 2013

Maybe @gdetrez ( 97849bd ) can help us shed some light on this?

@gdetrez
Copy link
Contributor

@gdetrez gdetrez commented Jun 28, 2013

Hi, sorry for the inconvenience 😕

I checked the fonts at https://github.com/Lokaltog/powerline-fonts and they should work with the new characters.
Apparently, if you are using iTerm, you need to set the patched font as both the 'Regular Font' and the 'Non-ASCII Font' and maybe clear your font cache. See #1872 (comment)

@stianeikeland
Copy link

@stianeikeland stianeikeland commented Jun 28, 2013

Thank you for the pointers :)
I was able to make it work with the new font here now following the steps in #1872, but also had to do a full reboot before it rendered the powerline symbols for some strange reason.

  1. quit iterm
  2. deleted all powerline fonts
  3. cleared font cache: sudo atsutil databases -remove
  4. added new font
  5. reboot
@chrw
Copy link
Contributor

@chrw chrw commented Jun 28, 2013

"DejaVu Sans Mono for Powerline" from https://github.com/Lokaltog/powerline-fonts worked for me! Thanks!
I'm using Ubuntu Linux 12.04 with GNOME Terminal.

EDIT: On my Mac using iTerm I used the "Menlo Regular for Powerline" font from the same repository. Worked too. Thanks.

@wwwdata
Copy link

@wwwdata wwwdata commented Jun 28, 2013

installing a new font worked for me fine. Used the same as @christianwolff

@ArtFeel
Copy link

@ArtFeel ArtFeel commented Jun 30, 2013

New «Menlo Regular for Powerline» from https://github.com/Lokaltog/powerline-fonts works good, but not so perfect as old font. Looks like symbols height become greater than height of the line.

@adben
Copy link
Contributor

@adben adben commented Jun 30, 2013

This issue is a bit annoying, already tried the steps at #1872 and rebooting as @stianeikeland suggested, this is the result with the new version of menlo;
schermafbeelding 2013-07-01 om 01 35 22

There is something else I can try before reverting to d6a36b1 ?

@adben
Copy link
Contributor

@adben adben commented Jul 1, 2013

@ArtFeel if you are using iTerm2 (Build 1.0.0.20130624) the configuration for the symbols is taken from your 'Non-ascii Font' configuration, try matching that configuration(size) with the one declared on the 'Regular Font'

@ArtFeel
Copy link

@ArtFeel ArtFeel commented Jul 1, 2013

@adben no, i'm using Terminal.app

@rixx
Copy link

@rixx rixx commented Jul 1, 2013

I upgraded today, had the same issue and fixed it by updating the agnoster theme file to this version: https://gist.github.com/agnoster/3712874

Restarted zsh and everything was fine again.

@sbirksted
Copy link

@sbirksted sbirksted commented Jul 10, 2013

Rixx's fixx worked like a charm.

@hasanIqbalAnik
Copy link

@hasanIqbalAnik hasanIqbalAnik commented Jul 31, 2013

it-ony 's command worked for me.

@jdan
Copy link

@jdan jdan commented Oct 9, 2013

Thank you @gdetrez! Been pulling my hair out for the last hour - turns out I still had Monaco selected as a Non-ASCII font.

@miro
Copy link

@miro miro commented Dec 8, 2013

With the instructions provided on oh-my-zsh theme page to the agnoster-theme this is still an issue. Reverted to the d6a36b1 -version and it works.

@dnath
Copy link

@dnath dnath commented Dec 19, 2013

Same here ... reverting to d6a36b1 works like a charm.

@mrbfrank
Copy link
Contributor

@mrbfrank mrbfrank commented Jan 28, 2014

I updated the config to this version, works great:
https://gist.github.com/agnoster/3712874#file-agnoster-zsh-theme

@pierreozoux
Copy link

@pierreozoux pierreozoux commented Jan 28, 2014

Hi, what is the point of the situation?

I would like to update oh-my-sh, but with this "workaround", I can't.

Should we make a pull request? Or anyone has an idea to make this working without workaround?

@mrbfrank
Copy link
Contributor

@mrbfrank mrbfrank commented Jan 28, 2014

I created a pull request: #2476
Rather than copying the config from agnoster's Gist, I simply corrected the SEGMENT_SEPARATOR character in our latest version. If you see any other invalid characters please notify, thanks.

@pradeepchaudharisc
Copy link

@pradeepchaudharisc pradeepchaudharisc commented Jan 27, 2017

It's 2017 and I still see the same issue. I think we should open this and fix it right.

--> Fix, If you land here again, Steps to Fix

  1. git clone https://github.com/powerline/fonts
  2. cd fonts
  3. ./install.sh from terminal / command line
  4. Open iTerm2->Preferences->Profiles->Change Font-> 12pt Meslo LG S DZ Regular for Powerline
@djsd123
Copy link

@djsd123 djsd123 commented Jan 27, 2017

@pradeepchaudharisc Or at least add some steps to the README.md 👍

@pradeepchaudharisc
Copy link

@pradeepchaudharisc pradeepchaudharisc commented Jan 27, 2017

@djsd123 I will send pull request soon 👯‍♂️

pradeephrish added a commit to pradeephrish/oh-my-zsh that referenced this issue Jan 27, 2017
A few invalid symbols in 'agnoster.zsh-theme' :
ohmyzsh#1906 (comment)

this issue got introduced in 2013 and people are still confused and don't know right way to fix it.
It would be awesome if we can put this in README.md

Thanks & Regards,
Pradeep
@juandiego26
Copy link

@juandiego26 juandiego26 commented Jun 22, 2017

@DanielGGordon thanks worked for me!!

@ismailhkose
Copy link

@ismailhkose ismailhkose commented Jul 5, 2017

I followed the all instructions at Ubuntu 16.04 for agnoster theme, but they didnt work. I am seeing invalid symbols

image

https://gist.github.com/agnoster/3712874
https://powerline.readthedocs.io/en/latest/installation/linux.html#font-installation
https://github.com/agnoster/agnoster-zsh-theme#agnosterzsh-theme
https://github.com/powerline/fonts instructions.

I installed patched powerline fonts and solarized theme.

Any comment?

@ismailhkose
Copy link

@ismailhkose ismailhkose commented Jul 5, 2017

echo "\ue0b0 \u00b1 \ue0a0 \u27a6 \u2718 \u26a1 \u2699"

image

I dont not see all character in the following picture
https://gist.githubusercontent.com/agnoster/3712874/raw/characters.png
image

@ismailhkose
Copy link

@ismailhkose ismailhkose commented Jul 6, 2017

I noticed that It was cygwin displaying issue. It was working in Ubuntu.
When I install powerline fonts to Windows, the problem was solved.

@piducancore
Copy link

@piducancore piducancore commented Oct 12, 2017

I was having this issue on Debian 9 with rxvt-unicode.
This answer helped me.
I'm using Hack font (fonts-hack-ttf package on debian) on my .Xresources:
URxvt.font: xft:Hack:size=8

@danigosa
Copy link

@danigosa danigosa commented Oct 16, 2017

For those poor bastards like me that had activated iTerm2's options antialised and non-Ascii fonts, appart from using powerline fonts, uncheck them!

@willguxy
Copy link

@willguxy willguxy commented Nov 2, 2017

(re)installing powerline fonts and change fonts in profile worked for me
https://github.com/powerline/fonts

@7rust
Copy link

@7rust 7rust commented Nov 17, 2017

If you are on macOS Sierra/ High Sierra you'll probably need this : http://powerline.readthedocs.io/en/master/installation/osx.html

Thank me later.

@karstengresch
Copy link

@karstengresch karstengresch commented Nov 24, 2017

lpredovas and - regarding the steps I followed - pradeepchaudharisc worked for me on iTerm2 but
only for new tabs.

I.e. already opened tabs did not change which made me a bit crazy for a while.

@erikjhordan-rey
Copy link

@erikjhordan-rey erikjhordan-rey commented Dec 2, 2017

if you are using macOS Sierra/ High Sierra, The problem can be solved installing https://github.com/powerline/fonts, so choose Meslo for Powerline.

@griffincox
Copy link

@griffincox griffincox commented Jan 9, 2018

thanks @erikcaffrey, that did the trick for me.

@erikjhordan-rey
Copy link

@erikjhordan-rey erikjhordan-rey commented Jan 9, 2018

@griffincox great!

@Oliverwong369
Copy link

@Oliverwong369 Oliverwong369 commented Jan 31, 2018

iTerm2 users need to set both the Regular font and the Non-ASCII Font in "iTerm > Preferences > Profiles > Text" to use a patched font ( Non-ASCII Font seems to cause the problem )

BTW iTerm2 looks better by binding Zsh with powerline plugin.

Preference:
https://github.com/powerline/fonts
https://powerline.readthedocs.io/en/latest/usage/shell-prompts.html#zsh-prompt

@Javirln
Copy link

@Javirln Javirln commented May 6, 2018

Hello guys, my problem is the following:
screen shot 2018-05-06 at 20 42 20
I cannot get rid of that little arrow at the beginning of the prompt. I have the latest version of agnoster and oh-my-zsh and my profile settings are the following:
screen shot 2018-05-06 at 20 45 36

@euf
Copy link

@euf euf commented Jun 7, 2018

@Javirln Hello, this little arrow is an indicator of the iTerm2 "Shell Integration" feature.

When shell integration is enabled, iTerm2 automatically adds a mark at each command prompt. Marks are indicated visually by a small blue triangle in the left margin.

See https://www.iterm2.com/documentation-shell-integration.html

@Hyped-247
Copy link

@Hyped-247 Hyped-247 commented Nov 5, 2018

Ok, so here is how I solved it.
screen shot 2018-11-05 at 12 45 37 pm
Make sure to select the power line font that you can get from cloning this. See the first circle in the picture.
And once you change the font, play around with the colors until you get the desired result. See the second circle in the picture.

@GuganVignesh
Copy link

@GuganVignesh GuganVignesh commented Feb 13, 2019

For Mac Terminal :

This need the Powerline fonts installed for the Mac, check here : https://github.com/powerline/fonts

Then if you find the colors to be little not suitable you can change in preferences > display > text > ANSI Colors (customise based on your vision)

After installation and customisation do not forget to restart the terminal, so that changes take effect on your terminal

@adrianmihalko
Copy link

@adrianmihalko adrianmihalko commented Feb 15, 2019

I installed the suggested fins, but it is not working.

screenshot 2019-02-15 at 18 30 28

@ruslanguns
Copy link

@ruslanguns ruslanguns commented Mar 18, 2019

I fixed it by changing my default font to DejaVu for e.g.

@mcornella
Copy link
Member

@mcornella mcornella commented Mar 25, 2019

One solution: #1906 (comment)
Summary: install Powerline fonts and set one of the fonts in your terminal emulator. If it doesn't work try another font.

@ohmyzsh ohmyzsh locked as resolved and limited conversation to collaborators Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
You can’t perform that action at this time.