Change HD derivative path from 44'/0' to 44'/216' to comply with SLIP #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OstlerDev
reviewed
Dec 13, 2023
| @@ -1,5 +1,5 @@ | |||
| 'use strict'; | |||
|
|
|||
| module.exports = [ | |||
| '193.70.122.58' | |||
There was a problem hiding this comment.
Maybe there are additional seed nodes we could add just in case these go offline. I will look into what other public nodes I can connect to and we could add all of them. Last time I saw there were at least 15 public nodes fully portforwarded. I know Mediciland is running one still (fcoin specifically), let me do some research and I will get back to this!
| @@ -483,7 +484,7 @@ main.keyPrefix = { | |||
| xprivkey: 0x01343c31, | |||
| xpubkey58: 'Fpub', | |||
| xprivkey58: 'Fprv', | |||
| coinType: 0 | |||
| coinType: 216 | |||
There was a problem hiding this comment.
This is perfect, thank you!
| @@ -20,10 +20,10 @@ const bcoin = require('../..'); | |||
| // m'/44' | |||
| const bip44Key = priv.derive(44, true); | |||
|
|
|||
| // m'/44'/0' | |||
| const bitcoinKey = bip44Key.derive(0, true); | |||
There was a problem hiding this comment.
Maybe we could modify the examples to say "floKey" just for clarity that it isn't the bitcoin derivation
|
This looks good to me, I appreciate you adding a dockerfile! I will go ahead and merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change HD derivative path from 44'/0' to 44'/216' to comply with SLIP-0044