-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change HD derivative path from 44'/0' to 44'/216' to comply with SLIP #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks great to me, I will look to try and get the MediciLand seed node and toss it in here, since that is one of the longest running nodes at the moment.
@@ -1,5 +1,5 @@ | |||
'use strict'; | |||
|
|||
module.exports = [ | |||
'193.70.122.58' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe there are additional seed nodes we could add just in case these go offline. I will look into what other public nodes I can connect to and we could add all of them. Last time I saw there were at least 15 public nodes fully portforwarded. I know Mediciland is running one still (fcoin specifically), let me do some research and I will get back to this!
@@ -483,7 +484,7 @@ main.keyPrefix = { | |||
xprivkey: 0x01343c31, | |||
xpubkey58: 'Fpub', | |||
xprivkey58: 'Fprv', | |||
coinType: 0 | |||
coinType: 216 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect, thank you!
@@ -20,10 +20,10 @@ const bcoin = require('../..'); | |||
// m'/44' | |||
const bip44Key = priv.derive(44, true); | |||
|
|||
// m'/44'/0' | |||
const bitcoinKey = bip44Key.derive(0, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could modify the examples to say "floKey" just for clarity that it isn't the bitcoin derivation
This looks good to me, I appreciate you adding a dockerfile! I will go ahead and merge it :) |
Change HD derivative path from 44'/0' to 44'/216' to comply with SLIP-0044