Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HD derivative path from 44'/0' to 44'/216' to comply with SLIP #18

Merged
merged 7 commits into from
Mar 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* text=auto eol=lf
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ yarn.lock
webpack.*.js
.DS_Store
tmp*
data/
9 changes: 9 additions & 0 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
FROM node:latest

WORKDIR /app
COPY . .
RUN npm install

EXPOSE 7315

CMD [ "/app/bin/fcoin", "--prefix", "/data", "--index-tx=true", "--index-address=true", "--log-level=debug", "--http-port=7315", "--bip37=true", "--max-outbound=30", "--max-inbound=30", "--listen=true" ]
11 changes: 11 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
version: '3'
services:
fcoind:
image: opennetwork/fcoin
ports:
- "7315:7315"
logging:
options:
max-size: "10m"
volumes:
- ./data:/data
6 changes: 3 additions & 3 deletions docs/examples/watch-only-wallet.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ const bcoin = require('../..');
// m'/44'
const bip44Key = priv.derive(44, true);

// m'/44'/0'
const bitcoinKey = bip44Key.derive(0, true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could modify the examples to say "floKey" just for clarity that it isn't the bitcoin derivation

// m'/44'/216'
const bitcoinKey = bip44Key.derive(216, true);

// m'/44'/0'/0'
// m'/44'/216'/0'
const accountKey = bitcoinKey.derive(0, true);

// account extended public key
Expand Down
2 changes: 1 addition & 1 deletion lib/net/seeds/main.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';

module.exports = [
'193.70.122.58'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there are additional seed nodes we could add just in case these go offline. I will look into what other public nodes I can connect to and we could add all of them. Last time I saw there were at least 15 public nodes fully portforwarded. I know Mediciland is running one still (fcoin specifically), let me do some research and I will get back to this!

'172.203.225.127'
];
3 changes: 2 additions & 1 deletion lib/protocol/networks.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ main.type = 'main';
*/

main.seeds = [
'flod.invertedtech.org',
'seed1.florincoin.org',
'node.oip.fun',
'flodns.oip.li',
Expand Down Expand Up @@ -483,7 +484,7 @@ main.keyPrefix = {
xprivkey: 0x01343c31,
xpubkey58: 'Fpub',
xprivkey58: 'Fprv',
coinType: 0
coinType: 216
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect, thank you!

};

/**
Expand Down
Loading