Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve project running with the dev command inside the .vulmix directory #146

Closed
ojvribeiro opened this issue May 13, 2023 · 1 comment · Fixed by #133
Closed

Serve project running with the dev command inside the .vulmix directory #146

ojvribeiro opened this issue May 13, 2023 · 1 comment · Fixed by #133
Assignees
Labels
Milestone

Comments

@ojvribeiro
Copy link
Owner

If the project is running with HMR enabled (npm run dev or yarn dev), the index.html file should be served in a folder inside .vulmix (maybe called build or client).

image

The _dist folder should only be created when the user runs the serve or the prod command (which should be renamed to build).

@ojvribeiro ojvribeiro added this to the 0.6.1-beta milestone May 13, 2023
@ojvribeiro ojvribeiro self-assigned this May 13, 2023
@ojvribeiro ojvribeiro linked a pull request May 15, 2023 that will close this issue
3 tasks
@ojvribeiro
Copy link
Owner Author

Completed in 77a5e03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant