Separate built-in aliases from preferred names. #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
sep-vars
branch
3 times, most recently
from
5cd39be
to
2f2e54f
Compare
- Rename `loopy-command-aliases` to `loopy-aliases`.
- Make names `loopy-command-aliases`, `loopy-custom-command-aliases`, and
`loopy-custom-command-parsers` obsolete.
- Move built-in aliases to user option `loopy-aliases`.
- Change structure of `loopy-aliases` from pairs of a alias and a true name to
pairs of a true name and a list of aliases.
- Update customization type of `loopy-aliases`.
- Better abstract working with aliases by creating functions
`loopy--get-true-name`, `loopy--get-aliases`, and `loopy--get-all-names`.
- Use these functions to replace things like `loopy--find-all-names` and
manually working with aliases.
- `loopy--find-all-names` can optionally use only the true name (much faster,
and what we normally do) and ignore certain names.
- Remove aliases from `loopy---accumulation-constructors`.
- Add support for aliases to `loopy--get-optimized-accum`.
- Create `loopy--def-special-processor` to create functions for handling aliases
of special macro arguments. This approach replaces
`loopy--process-special-marco-args`, which did not work well with all aliases.
Create the functions:
- `loopy--process-special-arg-with`
- `loopy--process-special-arg-before-do`
- `loopy--process-special-arg-flag`
- `loopy--process-special-arg-loop-name`
- `loopy--process-special-arg-after-do`
- `loopy--process-special-arg-wrap`
- `loopy--process-special-arg-accum-opt`
- `loopy--process-special-arg-without`
- `loopy--process-special-arg-finally-do`
- `loopy--process-special-arg-finally-return`
- `loopy--process-special-arg-finally-protect`
- Create function `loopy--clean-up-stack-vars`. This is just a convenience
function.
- Update `loopy--get-command-parser` to check all aliases.
- Simplify definition of `loopy-defalias`.
- Aliases should now *only* be defined with `loopy-defalias`. This makes
forward compatibility a lot easier, and simplifies search for all names
if we just flatten the recursion ahead of time (during definition).
- Update tests to use `loopy-defalias` instead of manipulating `loopy-aliases`.
- Move `loopy-defalias` from commands to vars.
- Update some comments.
- Convert `loopy-iter` to new structures.
- Add `loopy-iter-ignored-commands`, whose value is used when ignoring names in
`loopy--get-all-names`. This variable is always used with special macro
arguments and optionally used with commands when the `lax-naming` flag
is active.
- Try downloading map.el in tests. This did not work as expected.
- Defensive return `nil` to work around older versions of `map-do`.
`map-do` fails to return nil in older versions, like in `map.el` 2.0 (shipped
with Emacs 27). Ideally, we would instead download an updated version
when installing Loopy during tests.
- Update CHANGELOG.md.
- Update the README with info on breaking changes.
- Note the changes in aliases in the Org doc.
- Add Org documentation on `loopy-iter-ignored-names`.
- Update Texinfo doc.
- Remove `loopy--valid-macro-arguments`. No longer needed.
- Add unused variable `loopy--special-maro-argument-processors`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100.
loopy-command-aliasestoloopy-aliases.loopy-aliases.let*forwithinloopy-iter.loopy--valid-macro-arguments?loopy--accumulation-constructorsloopy-iter--sub-loop-command-ploopy--find-all-namesloopyandloopy-itermacro definitions