Fix error in optimized nconc end tracking.
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value should be `nreverse`-ed when prepending to a backwards list, but wasn't in all cases. This error was also made in `loopy--construct-accum-append`, though it was fixed there a few months ago.
okamsn
added a commit
that referenced
this pull request
Mar 14, 2023
- Update CHANGELOG and README. - Update version numbers. ## 0.11.1 Released 2023-03-13. ### Bugs Fixed - Fix `nconc`-ing onto the non-optimized end of an optimized collection, as in the below example ([#157]). ```elisp ;; => ((3 4 1 2) (1 2 3 4)) (loopy (accum-opt (opt-end end) (opt-start start)) (list i '((1 2) (3 4))) (nconc opt-end (copy-sequence i) :at start) (nconc opt-start (copy-sequence i) :at end) (finally-return opt-end opt-start)) ``` ### Other Changes - Added [Compat](https://github.com/emacs-compat/compat) as a dependency ([#152]). This is required for generalized variables in property lists. This feature was added in Emacs 28, which we had been creating if not found. It is better to let Compat do this for us. [#152]: #152 [#157]: #157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value should be
nreverse-ed when prepending to a backwards list,but wasn't in all cases.
This error was also made in
loopy--construct-accum-append, though it was fixedthere a few months ago.