Warn that :init is deprecated.
#163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
deprecate-init-keyword
branch
3 times, most recently
from
53efb84
to
1d0a4bb
Compare
- Add warnings for accumulation commands, `set`, and `set-prev`. - Remove `:init` from the Org doc. - Fix error in Org doc that said that `adjoin` had `:init`. - Update `set-prev` to work with `with` in the same manner. This command needed special attention due to how it queues values and how that combines with destructuring. This is tracked in #146.
okamsn
force-pushed
the
deprecate-init-keyword
branch
from
1d0a4bb
to
d9175cd
Compare
github-actions bot
added a commit
that referenced
this pull request
Mar 9, 2024
This commit was copied from the master branch. Commit: 0e08afc Author: okamsn <28612288+okamsn@users.noreply.github.com> Date: 2024-03-09 02:52:19 +0000 Remove the deprecated `:init` keyword argument. (#195) `:init` is replaced by the special macro argument `:with`. It was marked deprecated by PR #163. - Remove the relevant code. - Remove the relevant tests. - Edit a few tests. See also issue #146.
github-actions bot
added a commit
that referenced
this pull request
Mar 9, 2024
This commit was copied from the master branch. Commit: 0e08afc Author: okamsn <28612288+okamsn@users.noreply.github.com> Date: 2024-03-09 02:52:19 +0000 Remove the deprecated `:init` keyword argument. (#195) `:init` is replaced by the special macro argument `:with`. It was marked deprecated by PR #163. - Remove the relevant code. - Remove the relevant tests. - Edit a few tests. See also issue #146.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set, andset-prev.:initfrom the Org doc.adjoinhad:init.set-prevto work withwithin the same manner.This command needed special attention due to
how it queues values and how that combines with destructuring.