Add a :test to numbers. Deprecate the non-keyword arguments.
#172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
added
bug
- Modify `numbers`, `numbers-down`, and `numbers-up`. - Fix signalling an error when arguments which give directions conflict. - Add more tests. - Update docs, changelog, and readme. These arguments were meant to be similar to the arguments of Pythons `range` feature, but, depending on prior knowledge, would generally produce worse code. Cases in which the direction of the iteration (up or down) is unknown can now be handled by the new `:test` argument, which is more flexible than the non-keyword arguments anyway.
okamsn
force-pushed
the
numbers-func
branch
from
36c2faf
to
e4512ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numbers,numbers-down, andnumbers-up.These arguments were meant to be similar to the arguments of Pythons
rangefeature, but, depending on prior knowledge, would generally produce worse code.
Cases in which the direction of the iteration (up or down) is unknown can now be
handled by the new
:testargument, which is more flexible than the non-keywordarguments anyway.
See also issue #167.