-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iteration commands #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
multi-seq
branch
2 times, most recently
from
June 4, 2021 00:57
498ade6
to
0c8c8ea
Compare
Current commit message:
|
I think these changes are ready. They can also be viewed in the User @Luis-Henriquez-Perez, is there anything that you think should be changed? |
- Add heuristic to determine whether we should quote a list. - Create macro `loopy--defiteration`, similar in use to `loopy--defaccumulation`. - Add multi-sequence support to `list`, `array`, and `seq` commands. - Add macros `loopy--distribute-sequence-elements`, `loopy--distribute-array-elements`, and `loopy--distribute-list-elements`. - Add test to check for ELC files in the current working directory. These files can accidentally be used instead of the EL files, meaning that we won't see our changes during testing. - Add the keywords `from`, `upfrom`, `downfrom`, `to`, `upto`, `downto`, `above`, `below`, and `by` to commands `seq` and `array`, the `-ref` variants, the `-index` variant, and the `nums` command and variants. Add `:by` to `cons` and `list` and `variants`. - For `nums`, keep the positional arguments, but make them optional. - Add to library comments a note on how to find loop commands with Imenu. This is helpful now that we are using a macro to define them. - In code, add more headings for outline commands. - Add macro `loopy--plist-bind`. This macro is similar to `cl-destructuring-bind`, but for property lists. - Add function `loopy--find-start-by-end-dir-vals` to extract the needed values from plists. This function is used for all of commands which share so many keyword arguments. - Split "Iteration" section of Org doc into several sub-sections. - Break down into sections. - Add descriptions and custom ID's for sections. - Re-arrange commands. - Add a changelog. - Remove old TODO from `cons` command. This TODO no longer applies. - Improve Org documentation. - Improve function documentation strings. - Fix using variables that hold functions for `list`, `list-ref`, and `cons`.
This was referenced Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #65.
WORK IN PROGRESS
loopy-defaccumulation
.choose what to make the sequence resulting from distribution.
distributing elements for commands like
list-ref
, but it's still a good ideato change its optional
FUNC
argument to:by
, to be more like the commandlist
, for which an optionalFUNC
argument is no longer possible.