Improve accumulation command correctness. Fix some things. #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okamsn
force-pushed
the
command-compatibility
branch
3 times, most recently
from
8e9b3e8
to
3819e6e
Compare
- Fix bad instruction order in `loopy--parse-sub-loop-command`. - Some instructions for accumulation variables are order-sensitive. - Use `nconc` to update more variables. This is much faster than using the function `append`. - Use `nconc` when appending to the end of an accumulation variable. - Fix adding onto the end of lists of explicit variables. As anything can add onto the end, we need to use `nconc` each time, not just track where we think the end of the list is. - Add `loopy--get-accumulation-list-end-var` for way to use same variable to point to last link in list. We need to make sure that any accumulation command adding to the end of the list also updates the pointer to the last link in said list. - Update test `accumulation-conflicting-final-updates`. - Fix end-tracking in `adjoin`, `nconc`, `nunion`, `union`. - Add tests that `union`, `adjoin`, `collect`, and `append` non-destructive. - Update the CHANGELOG. - Add better way to check accumulation compatibility. - Update the Org documentation.
okamsn
force-pushed
the
command-compatibility
branch
from
3819e6e
to
9a40125
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loopy--parse-sub-loop-command.nconcto update more variables. This is much faster than using thefunction
append.onto the end, we need to use
nconceach time, not just track where we thinkthe end of the list is.
loopy--get-accumulation-list-end-varfor way to use same variable topoint to last link in list. We need to make sure that any accumulation command
adding to the end of the list also updates the pointer to the last link in said
list.
accumulation-conflicting-final-updates.adjoin,nconc,nunion,union.union,adjoin,collect, andappendnon-destructive.