Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NOD-384): support help option + refactor based on tests #7

Merged
merged 13 commits into from
Jul 4, 2023

Conversation

okeeffed
Copy link
Owner

@okeeffed okeeffed commented Jul 4, 2023

Changes

  • Adds help flag option.
  • Refactors CLI to display help on certain failures.
  • Refactors the match results state reducer helper.
  • Changes based on test failures from changes.
  • Adds in more test cases for missing explicit score scenarios (future improvement: derive "Game" from state other than default and throw error there instead).
  • Enables functionality to read in files.

Linear tickets

See attached ticket(s) for more details.

Branch changelog

Features

  • feat(NOD-384): add simple help message 90c146d
  • feat(NOD-384): update main file to support dev mode 7fe7cd9
  • feat: add more debug table results 03ffc4f
  • feat(NOD-384): abstract argv helper 719d14b
  • feat(NOD-385): support for stdin messages on CLI + argument 96cf9a7

Fixes

  • fix(NOD-384): should use bin cli name for help example 2f11f7d
  • fix: simplify and fix calculateMatchReducer based on debug table and manual output 4fd3a46
  • fix: add missing win scenarios e34783f
  • fix: add new lines to log to satisfy example output 14d992c

Chores

  • chore: add tournament files for debugging cli cb86498
  • chore: ignore eslint rule for easier-to-grok reducer + configure nodemon for paths and debug a4af95c

Other changes

  • refactor(NOD-384): cli errors -> print error + help and return 991642b
  • test: update tests to expect new lines from example output 713ec6d

@linear
Copy link

linear bot commented Jul 4, 2023

@linear
Copy link

linear bot commented Jul 4, 2023

@okeeffed okeeffed merged commit 92a41a7 into main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant