Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Usage of whitespace in ID of footer element #170

Closed
rowbean opened this issue Jul 21, 2020 · 1 comment · Fixed by #199
Closed

Usage of whitespace in ID of footer element #170

rowbean opened this issue Jul 21, 2020 · 1 comment · Fixed by #199
Labels
code good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rowbean
Copy link
Contributor

rowbean commented Jul 21, 2020

An ID must not contain any space characters(https://www.w3.org/TR/2011/WD-html5-20110525/elements.html#the-id-attribute)

Found in https://github.com/okfde/dev.codefor.de/blob/dev/themes/codefor-theme/layouts/partials/footer.html
@rowbean rowbean changed the title usage of whitespace in ID of footer element Usage of whitespace in ID of footer element Jul 21, 2020
@wagnerpeer
Copy link
Member

wagnerpeer commented Oct 1, 2020 •
edited
Loading

Looks like the id and the class attribute got mixed.

@ubergesundheit ubergesundheit added code good first issue Good for newcomers help wanted Extra attention is needed labels Oct 2, 2020
wagnerpeer added a commit to wagnerpeer/codefor.de that referenced this issue Oct 2, 2020
@wagnerpeer
Add class attribute in footer tags
8cbd2f2 
- Fixes okfde#170
@wagnerpeer wagnerpeer mentioned this issue Oct 2, 2020
Merged
wagnerpeer added a commit that referenced this issue Oct 3, 2020
@wagnerpeer @ubergesundheit
Add class attribute in footer tags (#199)
fb9bf1e 
* Add class attribute in footer tags

- Fixes #170

* remove space

Co-authored-by: Gerald Pape <ubergesundheit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add class attribute in footer tags wagnerpeer/codefor.de
3 participants
@ubergesundheit @wagnerpeer @rowbean