Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify how lab page is rendered #224

Merged
merged 3 commits into from
Jan 30, 2021
Merged

Simplify how lab page is rendered #224

merged 3 commits into from
Jan 30, 2021

Conversation

k-nut
Copy link
Member

@k-nut k-nut commented Jan 25, 2021

  • Show all content without accordion
  • Remove al to of bootstrap classes for a more
    simple layout

<div class="lab-content">
<h1 class="d-flex align-items-center flex-wrap justify-content-center">
<img src="/labs/hexagon/CodeFor-{{ .File.BaseFileName }}.svg" alt="Logo {{ .Title }}">
<div class="flex-grow-1"> {{.Title}} </div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="flex-grow-1"> {{.Title}} </div>
<div class="flex-grow-1 text-center"> {{.Title}} </div>

@ubergesundheit
Copy link
Collaborator

Really nice!

I would do some addtional changes:

@k-nut
Copy link
Member Author

k-nut commented Jan 30, 2021

@ubergesundheit done ✅
Please take another look.

@k-nut k-nut marked this pull request as ready for review January 30, 2021 20:13
Copy link
Collaborator

@ubergesundheit ubergesundheit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good 👌

- Show all content without accordion
- Remove al to of bootstrap classes for a more
  simple layout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants