Build stages on travis #134
Conversation
| script: coverage run -m unittest discover tests/journey | ||
|
|
||
| - stage: deploy | ||
| script: skip |
There was a problem hiding this comment.
is this really necessary to be explicit? I thought not adding any would automagically skip the scripting step if not stated.
There was a problem hiding this comment.
Sure! This is not necessary anymore. I will remove it.
There was a problem hiding this comment.
When you do I'll merge this =)
There was a problem hiding this comment.
I thought that I already had answered it but this line is necessary based on this piece of build job documentation because each step try to run a script but it's not necessary for a deploy job.
|
Tested the PR and it seems to be working, I look into the code, but didn't know what to judge, maybe @jtemporal can do that part. To test this PR, I clonned the project and ran into terminal: |
|
@anaschwendler would nice to try the same command |
Running Same happens with Trying to figure out how to run both tests with |
|
@cuducos just figured out! Thanks btw ❤ @lipemorais we need to add a That will be enough to make both test suites run =) |
|
Should we add a version bump or a |
Actually we a have a conflict here since #132 was merged before this one... If @lipemorais could go ahead and fix the conflicts by updating the version to This also means that #137 will also need some conflict solving but will be much better when taking into consideration releases. |
…alell right now :(
lipemorais
force-pushed
the
build-stages-on-travis
branch
from
276d0a6
to
5fdd055
Compare
What is the purpose of this Pull Request?
The purpose of this is introduce Build Stages feature on the project to address #129
What was done to achieve this purpose?
I edit the
.travis.ymlfile to use this new feature.How to test if it really works?
Here we have a green build using this feature.
Who can help reviewing it?
@Irio @cuducos @jtemporal @anaschwendler could help with this PR.