Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config option for location of site editing instructions #5

Open
rufuspollock opened this issue Apr 29, 2016 · 1 comment
Open

Config option for location of site editing instructions #5

rufuspollock opened this issue Apr 29, 2016 · 1 comment

Comments

@rufuspollock
Copy link
Member

rufuspollock commented Apr 29, 2016 •
edited
Loading

Currently the link for help instructions for editing is hard-coded to contribute however for many sites this is not appropriate.

Suggest we have a new config option editsitehowto and use this _includes/page-tools.html and default it to /contribute/. Not we should not preprend baseurl as this url could be offsite.
rufuspollock added a commit to frictionlessdata/website-old that referenced this issue Apr 29, 2016
@rufuspollock
[config,#3][s]: turn on "Improve this page" on every page by default.
52e2773 
* Have to add back "contribute" (how to edit this site) instructions
* Put them in /about/edit-site/ rather than /contribute/ as /contribute/ may be misleading (is it contribute to the project or the site)
* Had to updae _includes/page-tools.html to make the location of the edit customizable so it can point to /about/edit-site/
  * Raised an issue about this on the main theme repo: okfn/handbook-theme#5
@rufuspollock
Copy link
Member Author

Also in addition i suggest we merge the "contribute" section into one large page:

  • This will avoid issues where by moving contribute page you break it (the next and back links are location specific)
  • Also easier to use - you just have one big page (and the next icon is not obvious)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rufuspollock