Website 2023 #824
Merged
Website 2023 #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdata99
reviewed
May 23, 2023
| @@ -7,7 +7,7 @@ | |||
| <meta charset='UTF-8' /> | |||
| <meta name='viewport' content='width=device-width, initial-scale=1.0' /> | |||
| <title>{% block title %}SET A TITLE{% endblock %}</title> | |||
|
|
|||
| <link rel="stylesheet" href="./styles/main.css"> | |||
There was a problem hiding this comment.
Not sure if possibe but in django you usually use static
Something like
{% load static %}
...
<link rel="stylesheet" href="{% static 'css/main.css' %}">
If it's possible to move this css file to the static folder (and then use the Django command collectstatic
There was a problem hiding this comment.
Hi Andres, for sure this will need to change. The relative reference was for the vite build process, but I will change it when integrating the build process to the current one used by the website
avdata99
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new assets, css and convert handlebar templates to django templates based on the work from https://github.com/ishigami/okfn_front.
At the moment all pages except the frontpage have the layout broken because the new template used tailwindcss, and this breaks all the old css styles. The build process for the js and css are still being converted to the current website stack. The new page is using vite + rollup + postcss + tailwindcss for css/js build and minification.