Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website 2023 #824

Merged
merged 15 commits into from
May 24, 2023
Merged

Website 2023 #824

merged 15 commits into from
May 24, 2023

Conversation

aivuk
Copy link
Contributor

@aivuk aivuk commented May 23, 2023

Add new assets, css and convert handlebar templates to django templates based on the work from https://github.com/ishigami/okfn_front.

At the moment all pages except the frontpage have the layout broken because the new template used tailwindcss, and this breaks all the old css styles. The build process for the js and css are still being converted to the current website stack. The new page is using vite + rollup + postcss + tailwindcss for css/js build and minification.

@aivuk aivuk requested review from amercader and avdata99 May 23, 2023 16:19
@aivuk aivuk self-assigned this May 23, 2023
@@ -7,7 +7,7 @@
<meta charset='UTF-8' />
<meta name='viewport' content='width=device-width, initial-scale=1.0' />
<title>{% block title %}SET A TITLE{% endblock %}</title>

<link rel="stylesheet" href="./styles/main.css">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if possibe but in django you usually use static
Something like

{% load static %}
...

<link rel="stylesheet" href="{% static 'css/main.css' %}">

If it's possible to move this css file to the static folder (and then use the Django command collectstatic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andres, for sure this will need to change. The relative reference was for the vite build process, but I will change it when integrating the build process to the current one used by the website

Copy link
Member

@avdata99 avdata99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can give a try and rollback if fails.
Some HTML files already include {#each ...}, {#if ...} and other non-Django template language. Not sure how this works

@aivuk aivuk merged commit ddf7296 into develop May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants