Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FAQ fragment too long mobile #673

Merged
merged 1 commit into from Jan 4, 2020
Merged

Conversation

@ishchow
Copy link
Contributor

ishchow commented Dec 31, 2019

What this PR does / why we need it:
This PR removes a single CSS property in _faq.scss to fix an issue where the FAQ cards extend beyond the screen in mobile.

fixes #562

Special notes for your reviewer:

Release note:

Fix FAQ card width overflow on mobile
@deepcode-ci-bot

This comment has been minimized.

Copy link

deepcode-ci-bot bot commented Dec 31, 2019

DeepCode's analysis on #f177ce found:

  • 0 critical issues. ⚠️ 0 warnings and 0 minor issues. ✔️ 0 issues were fixed.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


☺️ If you want to provide feedback on our bot, here is how to contact us.

@ishchow

This comment has been minimized.

Copy link
Contributor Author

ishchow commented Dec 31, 2019

I edited exampleSite/content/fragments/faq/faq/question1.md to make the question longer to show the change in effect. But I ended up not pushing the changes to the .md file since it wasn't necessary to fix the issue.

Before this PR on syna/master (1f21cd6):
syna-before-change

After this PR:
syna-after-change

@stp-ip

This comment has been minimized.

Copy link
Member

stp-ip commented Dec 31, 2019

Thanks for the fix. Don't think there is any reason to keep the nowrap, so happy to merge once @mpourismaiel agrees.

Happy holidays.

Copy link
Member

mpourismaiel left a comment

It looks great. The nowrap was added in order to keep it in a single line but we didn't think about long titles in mobile devices.

@mpourismaiel mpourismaiel merged commit 94d6a04 into okkur:master Jan 4, 2020
3 checks passed
3 checks passed
test
Details
DeepCode Found no critical issues.
Details
deploy/netlify Deploy preview ready!
Details
@ishchow ishchow deleted the ishchow:fix-faq-on-mobile branch Jan 4, 2020
@ishchow

This comment has been minimized.

Copy link
Contributor Author

ishchow commented Jan 4, 2020

Thank you guys for the quick review! Happy new year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.