🐳 Docker build & publish #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amimart
force-pushed
the
build/docker-image
branch
from
2257ea3
to
a29f599
Compare
ErikssonJoakim
approved these changes
Sep 6, 2023
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings docker build and publish to the project, closes #2
Build details
The docker build is multi staged to minimise the final image size, dependencies fetching & proper build are separate instructions to take benefits from layers and avoid fetching dependencies again if not changed.
The runner image is based on onfinality/subql-node-cosmos keeping its entrypoint and allow to provide further arguments to the node.
The resulting container runs as the user
subql:subqlto avoid running as root.CI improvements
The docker lint & build steps has been added.
The publish action take care of the publication of the docker image on ghcr.io only, I didn't thought it would be useful to publish it on the docker hub in the early phases of this project, let me know if you think otherwise.