Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(style): enhance global design for sidebar and header #90

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix(style): enhance global design for sidebar and header #90

merged 1 commit into from
Sep 27, 2023

Conversation

fredericvilcot
Copy link
Contributor

@fredericvilcot fredericvilcot commented Sep 26, 2023 •
edited
Loading

This PR fixes following style issues:

  • header font is now bold
  • All titles anchors (#) are now hidden
  • sidebar style has been improved, especially for hover and active states

@fredericvilcot fredericvilcot marked this pull request as ready for review September 26, 2023 15:58
@fredericvilcot fredericvilcot self-assigned this Sep 26, 2023
ccamel
ccamel approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

MdechampG
MdechampG approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@MdechampG MdechampG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks @fredericvilcot !

@fredericvilcot fredericvilcot merged commit a7a1e2f into main Sep 27, 2023
7 checks passed
@fredericvilcot fredericvilcot deleted the fix/style-v2 branch September 27, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccamel ccamel ccamel approved these changes

@AnjaMis AnjaMis AnjaMis approved these changes

@MdechampG MdechampG MdechampG approved these changes

Assignees

@fredericvilcot fredericvilcot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fredericvilcot @ccamel @AnjaMis @MdechampG