Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scores and allScores JS objects to staff view #1267

Merged
merged 2 commits into from
May 5, 2018

Conversation

jathak
Copy link
Contributor

@jathak jathak commented May 5, 2018

Staff can now access scores as a JS object on their overview page for a student. scores should match the object embedded on the student view (only inactive assignments and public scores) while allScores includes active assignments and hidden scores.

Staff can now access scores as a JS object on their overview page
for a student. `scores` should match the object embedded on the
student view (only inactive assignments and public scores) while
`allScores` includes active assignments and hidden scores.
@jathak jathak requested a review from colinschoen May 5, 2018 19:34
Copy link
Member

@colinschoen colinschoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jathak jathak merged commit 9b5518b into master May 5, 2018
@jathak jathak deleted the scores-as-json-staff branch May 5, 2018 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants