fix: security question verification #1182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 6.4 #1182 +/- ##
==========================================
+ Coverage 93.32% 93.39% +0.07%
==========================================
Files 153 153
Lines 4418 4422 +4
Branches 994 995 +1
==========================================
+ Hits 4123 4130 +7
+ Misses 276 273 -3
Partials 19 19
Continue to review full report at Codecov.
|
shuowu
approved these changes
Apr 14, 2022
| @@ -134,7 +134,14 @@ export const SecurityQuestionAuthenticatorFactory = IdxAuthenticatorFactory.para | |||
| type: 'security_question', | |||
| methods: [ | |||
| { type: 'security_question' } | |||
| ] | |||
| ], | |||
| // if already enrolled, contextualData will be set | |||
There was a problem hiding this comment.
remove this comment?
There was a problem hiding this comment.
I put this in there deliberately, because it seems like the kind of thing we will forget. By default the factory will build an object for enrollment, but if you want to test verification you'll need to add that in yourself.
jaredperreault-okta
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with lib/idx/authenticator/SecurityQuestionVerification.ts where it was not accepting
credentials.answeras provided by the Sign-in Widget.When enrolling in security question there is no "contextualData", but this object is present when verifying. An omission in the mock used by SIW had it testing security question enrollment, but not verification. Fixing the mock revealed the issue with AuthJS.
Adding unit tests to cover these cases.